qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5112] SH4: convert a few helpers to TCG
Date: Sat, 30 Aug 2008 08:06:33 +0300	[thread overview]
Message-ID: <f43fc5580808292206l451e5bfblb5fad4e6492e09e@mail.gmail.com> (raw)
In-Reply-To: <E1KZCyL-0005aj-Me@cvs.savannah.gnu.org>

On Sat, Aug 30, 2008 at 2:01 AM, Aurelien Jarno <aurelien@aurel32.net> wrote:
>     case 0xc300:               /* trapa #imm */
> -       CHECK_NOT_DELAY_SLOT tcg_gen_movi_i32(cpu_pc, ctx->pc);
> -       gen_op_trapa(B7_0);
> +       CHECK_NOT_DELAY_SLOT
> +       tcg_gen_movi_i32(cpu_pc, ctx->pc);
> +       tcg_gen_movi_i32(cpu_T[0], B7_0);
> +       tcg_gen_helper_0_1(helper_trapa, cpu_T[0]);

Instead of introducing new uses of cpu_T[0], which you will probably
eliminate in the end of conversion, you could pass B7_0 using a
tcg_const temporary variable.

      reply	other threads:[~2008-08-30  5:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 23:01 [Qemu-devel] [5112] SH4: convert a few helpers to TCG Aurelien Jarno
2008-08-30  5:06 ` Blue Swirl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580808292206l451e5bfblb5fad4e6492e09e@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).