On 8/31/08, Gleb Natapov wrote: > On Sat, Aug 30, 2008 at 10:57:34PM +0300, Blue Swirl wrote: > > On 8/29/08, Gleb Natapov wrote: > > > On Thu, Aug 28, 2008 at 09:04:11PM +0300, Blue Swirl wrote: > > > > On 8/28/08, Gleb Natapov wrote: > > > > > + fw_cfg_add(fw_cfg, FW_CFG_ID, (uint8_t *)&bios_cfg_id, > > > > > + sizeof(bios_cfg_id)); > > > > > > > > On second thought, this is in host byte order, which is not a good idea. > > > > > > > > > > Is there some function to convert from host byte order to target byte > > > order? > > > > I made an updated version of the patch 1/6, with explicit little > > endian conversions. I'm not very happy with that. Another way would be > > to add functions just to put different size numbers into device and > > they would hide the conversion. > > > > So what approach we should go with? We can go with the second one (add > functions for each type) and extend interface as needed. This version adds the functions, now the interface is much better. I updated the other patches too.