From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KcFZY-0007ch-T6 for qemu-devel@nongnu.org; Sun, 07 Sep 2008 04:24:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KcFZX-0007Z1-8c for qemu-devel@nongnu.org; Sun, 07 Sep 2008 04:24:40 -0400 Received: from [199.232.76.173] (port=50212 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KcFZX-0007Ye-3j for qemu-devel@nongnu.org; Sun, 07 Sep 2008 04:24:39 -0400 Received: from wf-out-1314.google.com ([209.85.200.171]:62959) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KcFZW-0001uI-Nd for qemu-devel@nongnu.org; Sun, 07 Sep 2008 04:24:38 -0400 Received: by wf-out-1314.google.com with SMTP id 27so1112989wfd.4 for ; Sun, 07 Sep 2008 01:24:38 -0700 (PDT) Message-ID: Date: Sun, 7 Sep 2008 11:24:37 +0300 From: "Blue Swirl" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_84996_27674620.1220775877931" Subject: [Qemu-devel] [PATCH, RFC] ld flag --warn-common Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel ------=_Part_84996_27674620.1220775877931 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, These trivial patches enable linker flag --warn-common and fix the warnings caused by enabling the flag. I think on some platforms (Solaris?) the linker used by gcc is not GNU ld. If this is true, the patch would break compilation on those hosts and logic in configure would need to be more complex. Please confirm. ------=_Part_84996_27674620.1220775877931 Content-Type: plain/text; name=ld_warn_common.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fkteazmf Content-Disposition: attachment; filename=ld_warn_common.diff SW5kZXg6IHFlbXUvY29uZmlndXJlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9jb25maWd1cmUJ MjAwOC0wOS0wNyAwNzozNjozNy4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvY29uZmlndXJlCTIw MDgtMDktMDcgMDc6Mzc6MDQuMDAwMDAwMDAwICswMDAwCkBAIC0zNDcsNyArMzQ3LDcgQEAKIAog IyBkZWZhdWx0IGZsYWdzIGZvciBhbGwgaG9zdHMKIENGTEFHUz0iJENGTEFHUyAtV2FsbCAtV3Vu ZGVmIC1Xd3JpdGUtc3RyaW5ncyAtTzIgLWcgLWZuby1zdHJpY3QtYWxpYXNpbmciCi1MREZMQUdT PSIkTERGTEFHUyAtZyIKK0xERkxBR1M9IiRMREZMQUdTIC1nIC1XbCwtLXdhcm4tY29tbW9uIgog aWYgdGVzdCAiJHdlcnJvciIgPSAieWVzIiA7IHRoZW4KIENGTEFHUz0iJENGTEFHUyAtV2Vycm9y IgogZmkK ------=_Part_84996_27674620.1220775877931 Content-Type: plain/text; name=fix_ld_warn_common.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fkteb8cv Content-Disposition: attachment; filename=fix_ld_warn_common.diff SW5kZXg6IHFlbXUvYmxvY2tfaW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2Jsb2NrX2lu dC5oCTIwMDgtMDktMDcgMDc6Mzc6MTQuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2Jsb2NrX2lu dC5oCTIwMDgtMDktMDcgMDc6Mzc6MzMuMDAwMDAwMDAwICswMDAwCkBAIC0xNDUsNiArMTQ1LDYg QEAKICAgICAgICAgICAgICAgICAgICB2b2lkICpvcGFxdWUpOwogdm9pZCBxZW11X2Fpb19yZWxl YXNlKHZvaWQgKnApOwogCi1CbG9ja0RyaXZlclN0YXRlICpiZHJ2X2ZpcnN0OworZXh0ZXJuIEJs b2NrRHJpdmVyU3RhdGUgKmJkcnZfZmlyc3Q7CiAKICNlbmRpZiAvKiBCTE9DS19JTlRfSCAqLwpJ bmRleDogcWVtdS9ody9hcm0tbWlzYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9ody9hcm0t bWlzYy5oCTIwMDgtMDktMDcgMDc6Mzc6MTQuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2h3L2Fy bS1taXNjLmgJMjAwOC0wOS0wNyAwNzozNzozMy4wMDAwMDAwMDAgKzAwMDAKQEAgLTM3LDcgKzM3 LDcgQEAKIAogLyogTXVsdGlwbGljYXRpb24gZmFjdG9yIHRvIGNvbnZlcnQgZnJvbSBzeXN0ZW0g Y2xvY2sgdGlja3MgdG8gcWVtdSB0aW1lcgogICAgdGlja3MuICAqLwotaW50IHN5c3RlbV9jbG9j a19zY2FsZTsKK2V4dGVybiBpbnQgc3lzdGVtX2Nsb2NrX3NjYWxlOwogcWVtdV9pcnEgKmFybXY3 bV9udmljX2luaXQoQ1BVU3RhdGUgKmVudik7CiAKIC8qIHN0ZWxsYXJpc19lbmVudC5jICovCklu ZGV4OiBxZW11L2Jsb2NrLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2Jsb2NrLmMJMjAwOC0w OS0wNyAwNzozNzoxNC4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvYmxvY2suYwkyMDA4LTA5LTA3 IDA3OjM3OjMzLjAwMDAwMDAwMCArMDAwMApAQCAtNTYsNiArNTYsOCBAQAogc3RhdGljIGludCBi ZHJ2X3dyaXRlX2VtKEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBpbnQ2NF90IHNlY3Rvcl9udW0sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgdWludDhfdCAqYnVmLCBpbnQgbmJfc2VjdG9y cyk7CiAKK0Jsb2NrRHJpdmVyU3RhdGUgKmJkcnZfZmlyc3Q7CisKIHN0YXRpYyBCbG9ja0RyaXZl ciAqZmlyc3RfZHJ2OwogCiBpbnQgcGF0aF9pc19hYnNvbHV0ZShjb25zdCBjaGFyICpwYXRoKQpJ bmRleDogcWVtdS9ody9hcm12N21fbnZpYy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9ody9h cm12N21fbnZpYy5jCTIwMDgtMDktMDcgMDc6Mzk6NDQuMDAwMDAwMDAwICswMDAwCisrKyBxZW11 L2h3L2FybXY3bV9udmljLmMJMjAwOC0wOS0wNyAwNzozOTo1MS4wMDAwMDAwMDAgKzAwMDAKQEAg LTUwLDYgKzUwLDggQEAKICNkZWZpbmUgU1lTVElDS19DTEtTT1VSQ0UgKDEgPDwgMikKICNkZWZp bmUgU1lTVElDS19DT1VOVEZMQUcgKDEgPDwgMTYpCiAKK2ludCBzeXN0ZW1fY2xvY2tfc2NhbGU7 CisKIC8qIENvbnZlcnNpb24gZmFjdG9yIGZyb20gcWVtdSB0aW1lciB0byBTeXNUaWNrIGZyZXF1 ZW5jaWVzLiAgKi8KIHN0YXRpYyBpbmxpbmUgaW50NjRfdCBzeXN0aWNrX3NjYWxlKG52aWNfc3Rh dGUgKnMpCiB7Cg== ------=_Part_84996_27674620.1220775877931--