From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KcJP6-0002XG-Gt
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 08:30:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KcJP4-0002WI-2i
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 08:30:07 -0400
Received: from [199.232.76.173] (port=34343 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KcJP2-0002W6-N9
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 08:30:05 -0400
Received: from wf-out-1314.google.com ([209.85.200.169]:31494)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KcJP2-000403-CP
	for qemu-devel@nongnu.org; Sun, 07 Sep 2008 08:30:04 -0400
Received: by wf-out-1314.google.com with SMTP id 27so1158556wfd.4
	for <qemu-devel@nongnu.org>; Sun, 07 Sep 2008 05:30:03 -0700 (PDT)
Message-ID: <f43fc5580809070530o44406d6dl6a1a55c6247db8d@mail.gmail.com>
Date: Sun, 7 Sep 2008 15:30:03 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common
In-Reply-To: <cef699d70809070450p53179948l58bab9adade41109@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_85983_654296.1220790603548"
References: <f43fc5580809070124v10da89bcm109e771369400439@mail.gmail.com>
	<cef699d70809070450p53179948l58bab9adade41109@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

------=_Part_85983_654296.1220790603548
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 9/7/08, Ben Taylor <bentaylor.solx86@gmail.com> wrote:
> On Sun, Sep 7, 2008 at 4:24 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>  > Hi,
>  >
>  > These trivial patches enable linker flag --warn-common and fix the
>  > warnings caused by enabling the flag.
>  >
>  > I think on some platforms (Solaris?) the linker used by gcc is not GNU
>  > ld. If this is true, the patch would break compilation on those hosts
>  > and logic in configure would need to be more complex. Please confirm.
>
>
> yes, Solaris does not use gnu ld, it uses it's own linker.

Could you test if with this patch applied, "other ld" is printed when
configuring?

------=_Part_85983_654296.1220790603548
Content-Type: plain/text; name=ld_warn_common.diff
Content-Transfer-Encoding: base64
X-Attachment-Id: f_fktn404o
Content-Disposition: attachment; filename=ld_warn_common.diff

SW5kZXg6IHFlbXUvY29uZmlndXJlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9jb25maWd1cmUJ
MjAwOC0wOS0wNyAxMjowNDo1NS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvY29uZmlndXJlCTIw
MDgtMDktMDcgMTI6MjU6MDQuMDAwMDAwMDAwICswMDAwCkBAIC0zNTIsNiArMzUyLDEzIEBACiBD
RkxBR1M9IiRDRkxBR1MgLVdlcnJvciIKIGZpCiAKK2lmIGxkIC0tdmVyc2lvbiB8IGdyZXAgLXEg
IkdOVSBsZCIgMj4vZGV2L251bGwgOyB0aGVuCisgICAgTERGTEFHUz0iJExERkxBR1MgLVdsLC0t
d2Fybi1jb21tb24iCisgICAgZWNobyBnb3QgR05VIGxkCitlbHNlCisgICAgZWNobyBvdGhlciBs
ZAorZmkKKwogIwogIyBJZiBjcHUgfj0gc3BhcmMgYW5kICBzcGFyY19jcHUgaGFzbid0IGJlZW4g
ZGVmaW5lZCwgcGx1ZyBpbiB0aGUgcmlnaHQKICMgQVJDSF9DRkxBR1MvQVJDSF9MREZMQUdTIChh
c3N1bWUgc3BhcmNfdjhwbHVzIGZvciAzMi1iaXQgYW5kIHNwYXJjX3Y5IGZvciA2NC1iaXQpCg==

------=_Part_85983_654296.1220790603548--