From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kd5a8-0007s1-4N
	for qemu-devel@nongnu.org; Tue, 09 Sep 2008 11:56:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kd5a7-0007rY-Cq
	for qemu-devel@nongnu.org; Tue, 09 Sep 2008 11:56:43 -0400
Received: from [199.232.76.173] (port=35107 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kd5a7-0007rO-0m
	for qemu-devel@nongnu.org; Tue, 09 Sep 2008 11:56:43 -0400
Received: from mail-gx0-f19.google.com ([209.85.217.19]:64143)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Kd5a6-00041P-QS
	for qemu-devel@nongnu.org; Tue, 09 Sep 2008 11:56:42 -0400
Received: by gxk12 with SMTP id 12so10704310gxk.10
	for <qemu-devel@nongnu.org>; Tue, 09 Sep 2008 08:56:41 -0700 (PDT)
Message-ID: <f43fc5580809090856p3c503f09l4b0ee648c12a8c44@mail.gmail.com>
Date: Tue, 9 Sep 2008 18:56:40 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common
In-Reply-To: <cef699d70809090814n1bd56833r3cc1356d180eb821@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f43fc5580809070124v10da89bcm109e771369400439@mail.gmail.com>
	<cef699d70809070450p53179948l58bab9adade41109@mail.gmail.com>
	<f43fc5580809070530o44406d6dl6a1a55c6247db8d@mail.gmail.com>
	<cef699d70809090814n1bd56833r3cc1356d180eb821@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 9/9/08, Ben Taylor <bentaylor.solx86@gmail.com> wrote:
> On Sun, Sep 7, 2008 at 8:30 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>  > On 9/7/08, Ben Taylor <bentaylor.solx86@gmail.com> wrote:
>  >> On Sun, Sep 7, 2008 at 4:24 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>  >>  > Hi,
>  >>  >
>  >>  > These trivial patches enable linker flag --warn-common and fix the
>  >>  > warnings caused by enabling the flag.
>  >>  >
>  >>  > I think on some platforms (Solaris?) the linker used by gcc is not GNU
>  >>  > ld. If this is true, the patch would break compilation on those hosts
>  >>  > and logic in configure would need to be more complex. Please confirm.
>  >>
>  >>
>  >> yes, Solaris does not use gnu ld, it uses it's own linker.
>  >
>  > Could you test if with this patch applied, "other ld" is printed when
>  > configuring?
>
>
> Confirmed that it prints "other ld" on Solaris.

Thanks for testing, I'll prepare an updated version.