From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kd6MC-00043p-SZ for qemu-devel@nongnu.org; Tue, 09 Sep 2008 12:46:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kd6MB-00043d-9J for qemu-devel@nongnu.org; Tue, 09 Sep 2008 12:46:23 -0400 Received: from [199.232.76.173] (port=51570 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kd6MB-00043a-3o for qemu-devel@nongnu.org; Tue, 09 Sep 2008 12:46:23 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:43200) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kd6MA-0004f1-VZ for qemu-devel@nongnu.org; Tue, 09 Sep 2008 12:46:23 -0400 Received: by gxk12 with SMTP id 12so10867281gxk.10 for ; Tue, 09 Sep 2008 09:46:21 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2008 19:46:19 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5127_30675209.1220978780032" References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_5127_30675209.1220978780032 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/9/08, Blue Swirl wrote: > On 9/9/08, Ben Taylor wrote: > > On Sun, Sep 7, 2008 at 8:30 AM, Blue Swirl wrote: > > > On 9/7/08, Ben Taylor wrote: > > >> On Sun, Sep 7, 2008 at 4:24 AM, Blue Swirl wrote: > > >> > Hi, > > >> > > > >> > These trivial patches enable linker flag --warn-common and fix the > > >> > warnings caused by enabling the flag. > > >> > > > >> > I think on some platforms (Solaris?) the linker used by gcc is not GNU > > >> > ld. If this is true, the patch would break compilation on those hosts > > >> > and logic in configure would need to be more complex. Please confirm. > > >> > > >> > > >> yes, Solaris does not use gnu ld, it uses it's own linker. > > > > > > Could you test if with this patch applied, "other ld" is printed when > > > configuring? > > > > > > Confirmed that it prints "other ld" on Solaris. > > > Thanks for testing, I'll prepare an updated version. Here they are. I think I'll commit them in a few days unless there are objections. ------=_Part_5127_30675209.1220978780032 Content-Type: plain/text; name=ld_warn_common.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fkwr3ccq Content-Disposition: attachment; filename=ld_warn_common.diff SW5kZXg6IHFlbXUvY29uZmlndXJlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9jb25maWd1cmUJ MjAwOC0wOS0wOSAxNjozODoyNy4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvY29uZmlndXJlCTIw MDgtMDktMDkgMTY6Mzk6MDguMDAwMDAwMDAwICswMDAwCkBAIC0zNTIsNiArMzUyLDEwIEBACiBD RkxBR1M9IiRDRkxBR1MgLVdlcnJvciIKIGZpCiAKK2lmIGxkIC0tdmVyc2lvbiAyPi9kZXYvbnVs bCB8IGdyZXAgLXEgIkdOVSBsZCIgOyB0aGVuCisgICAgTERGTEFHUz0iJExERkxBR1MgLVdsLC0t d2Fybi1jb21tb24iCitmaQorCiAjCiAjIElmIGNwdSB+PSBzcGFyYyBhbmQgIHNwYXJjX2NwdSBo YXNuJ3QgYmVlbiBkZWZpbmVkLCBwbHVnIGluIHRoZSByaWdodAogIyBBUkNIX0NGTEFHUy9BUkNI X0xERkxBR1MgKGFzc3VtZSBzcGFyY192OHBsdXMgZm9yIDMyLWJpdCBhbmQgc3BhcmNfdjkgZm9y IDY0LWJpdCkK ------=_Part_5127_30675209.1220978780032 Content-Type: plain/text; name=fix_ld_warn_common.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fkwr3km1 Content-Disposition: attachment; filename=fix_ld_warn_common.diff SW5kZXg6IHFlbXUvYmxvY2tfaW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2Jsb2NrX2lu dC5oCTIwMDgtMDktMDkgMTY6MjI6NDIuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2Jsb2NrX2lu dC5oCTIwMDgtMDktMDkgMTY6Mzk6MTIuMDAwMDAwMDAwICswMDAwCkBAIC0xNDUsNiArMTQ1LDYg QEAKICAgICAgICAgICAgICAgICAgICB2b2lkICpvcGFxdWUpOwogdm9pZCBxZW11X2Fpb19yZWxl YXNlKHZvaWQgKnApOwogCi1CbG9ja0RyaXZlclN0YXRlICpiZHJ2X2ZpcnN0OworZXh0ZXJuIEJs b2NrRHJpdmVyU3RhdGUgKmJkcnZfZmlyc3Q7CiAKICNlbmRpZiAvKiBCTE9DS19JTlRfSCAqLwpJ bmRleDogcWVtdS9ody9hcm0tbWlzYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9ody9hcm0t bWlzYy5oCTIwMDgtMDktMDkgMTY6MjI6NDIuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2h3L2Fy bS1taXNjLmgJMjAwOC0wOS0wOSAxNjozOToxMi4wMDAwMDAwMDAgKzAwMDAKQEAgLTM3LDcgKzM3 LDcgQEAKIAogLyogTXVsdGlwbGljYXRpb24gZmFjdG9yIHRvIGNvbnZlcnQgZnJvbSBzeXN0ZW0g Y2xvY2sgdGlja3MgdG8gcWVtdSB0aW1lcgogICAgdGlja3MuICAqLwotaW50IHN5c3RlbV9jbG9j a19zY2FsZTsKK2V4dGVybiBpbnQgc3lzdGVtX2Nsb2NrX3NjYWxlOwogcWVtdV9pcnEgKmFybXY3 bV9udmljX2luaXQoQ1BVU3RhdGUgKmVudik7CiAKIC8qIHN0ZWxsYXJpc19lbmVudC5jICovCklu ZGV4OiBxZW11L2Jsb2NrLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2Jsb2NrLmMJMjAwOC0w OS0wOSAxNjozODozMS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvYmxvY2suYwkyMDA4LTA5LTA5 IDE2OjM5OjEyLjAwMDAwMDAwMCArMDAwMApAQCAtNTYsNiArNTYsOCBAQAogc3RhdGljIGludCBi ZHJ2X3dyaXRlX2VtKEJsb2NrRHJpdmVyU3RhdGUgKmJzLCBpbnQ2NF90IHNlY3Rvcl9udW0sCiAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgdWludDhfdCAqYnVmLCBpbnQgbmJfc2VjdG9y cyk7CiAKK0Jsb2NrRHJpdmVyU3RhdGUgKmJkcnZfZmlyc3Q7CisKIHN0YXRpYyBCbG9ja0RyaXZl ciAqZmlyc3RfZHJ2OwogCiBpbnQgcGF0aF9pc19hYnNvbHV0ZShjb25zdCBjaGFyICpwYXRoKQpJ bmRleDogcWVtdS9ody9hcm12N21fbnZpYy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9ody9h cm12N21fbnZpYy5jCTIwMDgtMDktMDkgMTY6MjI6NDIuMDAwMDAwMDAwICswMDAwCisrKyBxZW11 L2h3L2FybXY3bV9udmljLmMJMjAwOC0wOS0wOSAxNjozOToxMi4wMDAwMDAwMDAgKzAwMDAKQEAg LTUwLDYgKzUwLDggQEAKICNkZWZpbmUgU1lTVElDS19DTEtTT1VSQ0UgKDEgPDwgMikKICNkZWZp bmUgU1lTVElDS19DT1VOVEZMQUcgKDEgPDwgMTYpCiAKK2ludCBzeXN0ZW1fY2xvY2tfc2NhbGU7 CisKIC8qIENvbnZlcnNpb24gZmFjdG9yIGZyb20gcWVtdSB0aW1lciB0byBTeXNUaWNrIGZyZXF1 ZW5jaWVzLiAgKi8KIHN0YXRpYyBpbmxpbmUgaW50NjRfdCBzeXN0aWNrX3NjYWxlKG52aWNfc3Rh dGUgKnMpCiB7Cg== ------=_Part_5127_30675209.1220978780032--