From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5187] Use signalfd() to work around signal/select race
Date: Wed, 10 Sep 2008 19:55:00 +0300 [thread overview]
Message-ID: <f43fc5580809100955r16ef5bd8o5aff2ebf9900dd96@mail.gmail.com> (raw)
In-Reply-To: <E1KdRsd-0003t8-G0@cvs.savannah.gnu.org>
On 9/10/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Revision: 5187
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5187
> Author: aliguori
> Date: 2008-09-10 15:45:19 +0000 (Wed, 10 Sep 2008)
>
> Log Message:
> -----------
> Use signalfd() to work around signal/select race
>
> This patch introduces signalfd() to work around the signal/select race in
> checking for AIO completions. For platforms that don't support signalfd(), we
> emulate it with threads.
>
> There was a long discussion about this approach. I don't believe there are any
> fundamental problems with this approach and I believe eliminating the use of
> signals is a good thing.
>
> I've tested Windows and Linux using Windows and Linux guests. I've also checked
> for disk IO performance regressions.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> Modified Paths:
> --------------
> trunk/Makefile
> trunk/Makefile.target
> trunk/block-raw-posix.c
> trunk/block-raw-win32.c
> trunk/block.c
> trunk/block.h
> trunk/vl.c
The file compatfd.h is missing.
next prev parent reply other threads:[~2008-09-10 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 15:45 [Qemu-devel] [5187] Use signalfd() to work around signal/select race Anthony Liguori
2008-09-10 16:55 ` Blue Swirl [this message]
[not found] ` <4246B478-DB41-4AF6-962A-2B2ECD1B371C@hotmail.com>
2008-09-10 17:19 ` C.W. Betts
2008-09-10 18:18 ` Anthony Liguori
2008-09-11 16:03 ` Laurent Vivier
2008-09-11 16:28 ` Anthony Liguori
2008-09-11 18:10 ` Anthony Liguori
2008-09-11 20:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580809100955r16ef5bd8o5aff2ebf9900dd96@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).