From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KdSy7-0002zn-Bf
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 12:55:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KdSy6-0002zI-MN
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 12:55:02 -0400
Received: from [199.232.76.173] (port=47485 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KdSy6-0002z4-GG
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 12:55:02 -0400
Received: from mail-gx0-f19.google.com ([209.85.217.19]:42187)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KdSy6-0004Bm-2g
	for qemu-devel@nongnu.org; Wed, 10 Sep 2008 12:55:02 -0400
Received: by gxk12 with SMTP id 12so13974448gxk.10
	for <qemu-devel@nongnu.org>; Wed, 10 Sep 2008 09:55:01 -0700 (PDT)
Message-ID: <f43fc5580809100955r16ef5bd8o5aff2ebf9900dd96@mail.gmail.com>
Date: Wed, 10 Sep 2008 19:55:00 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [5187] Use signalfd() to work around signal/select
	race
In-Reply-To: <E1KdRsd-0003t8-G0@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KdRsd-0003t8-G0@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 9/10/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Revision: 5187
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5187
>  Author:   aliguori
>  Date:     2008-09-10 15:45:19 +0000 (Wed, 10 Sep 2008)
>
>  Log Message:
>  -----------
>  Use signalfd() to work around signal/select race
>
>  This patch introduces signalfd() to work around the signal/select race in
>  checking for AIO completions.  For platforms that don't support signalfd(), we
>  emulate it with threads.
>
>  There was a long discussion about this approach.  I don't believe there are any
>  fundamental problems with this approach and I believe eliminating the use of
>  signals is a good thing.
>
>  I've tested Windows and Linux using Windows and Linux guests.  I've also checked
>  for disk IO performance regressions.
>
>  Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
>  Modified Paths:
>  --------------
>     trunk/Makefile
>     trunk/Makefile.target
>     trunk/block-raw-posix.c
>     trunk/block-raw-win32.c
>     trunk/block.c
>     trunk/block.h
>     trunk/vl.c

The file compatfd.h is missing.