From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KeAlC-0007r7-WB for qemu-devel@nongnu.org; Fri, 12 Sep 2008 11:40:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KeAlB-0007qN-JE for qemu-devel@nongnu.org; Fri, 12 Sep 2008 11:40:38 -0400 Received: from [199.232.76.173] (port=46314 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KeAlB-0007qK-A5 for qemu-devel@nongnu.org; Fri, 12 Sep 2008 11:40:37 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:39499) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KeAlA-0004Pz-Oh for qemu-devel@nongnu.org; Fri, 12 Sep 2008 11:40:37 -0400 Received: by gxk12 with SMTP id 12so19142960gxk.10 for ; Fri, 12 Sep 2008 08:40:35 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2008 18:40:34 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH 1/10] Refactor QEMUFile for live migration In-Reply-To: <1220989802-13706-2-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1220989802-13706-1-git-send-email-aliguori@us.ibm.com> <1220989802-13706-2-git-send-email-aliguori@us.ibm.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Chris Wright , Uri Lublin , Anthony Liguori , kvm@vger.kernel.org On 9/9/08, Anthony Liguori wrote: > To support live migration, we override QEMUFile so that instead of writing to > disk, the save/restore state happens over a network connection. > > This patch makes QEMUFile read/write operations function pointers so that we > can override them for live migration. > +typedef struct QEMUFileUnix > +{ > + FILE *outfile; > +} QEMUFileUnix; I'd rather use name stdio/StdIO instead of Unix, this code is not Unix dependent.