From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ken29-0000Et-VH for qemu-devel@nongnu.org; Sun, 14 Sep 2008 04:32:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ken28-0000EV-PX for qemu-devel@nongnu.org; Sun, 14 Sep 2008 04:32:41 -0400 Received: from [199.232.76.173] (port=49874 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ken28-0000EK-Ha for qemu-devel@nongnu.org; Sun, 14 Sep 2008 04:32:40 -0400 Received: from wf-out-1314.google.com ([209.85.200.169]:12698) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ken28-0003xj-5g for qemu-devel@nongnu.org; Sun, 14 Sep 2008 04:32:40 -0400 Received: by wf-out-1314.google.com with SMTP id 27so1524724wfd.4 for ; Sun, 14 Sep 2008 01:32:39 -0700 (PDT) Message-ID: Date: Sun, 14 Sep 2008 11:32:38 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [5204] husb: Make control transactions asynchronous (Max Krasnyansky) In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_16905_16802799.1221381158827" References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_16905_16802799.1221381158827 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/14/08, Blue Swirl wrote: > On 9/14/08, Anthony Liguori wrote: > > Revision: 5204 > > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5204 > > Author: aliguori > > Date: 2008-09-14 01:06:09 +0000 (Sun, 14 Sep 2008) > > > > Log Message: > > ----------- > > husb: Make control transactions asynchronous (Max Krasnyansky) > > > > USB is 99.8% async now :). 0.2% is the three control requests that > > we need to execute synchronously. We could off-load that to a thread > > or something but it's not worth the pain since those requests are > > performed only during device initialization (ie when device is > > connected to the VM). > > > > The change is a bit bigger than I wanted due to the fact that generic > > handle_packet()/handle_control() interface was not designed for > > async transactions. So I ended up adding custom handle_packet() > > code to usb-linux. We can make that generic if/when some other > > component needs it. > > > > +#include > > > My Debian machines do not have this header file. Is it only used for > the structure definition that was removed by the commit? This patch removes the include and adds the structures needed as well as one missing "static". ------=_Part_16905_16802799.1221381158827 Content-Type: plain/text; name=fix_usb.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fl3erud5 Content-Disposition: attachment; filename=fix_usb.diff SW5kZXg6IHFlbXUvdXNiLWxpbnV4LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL3VzYi1saW51 eC5jCTIwMDgtMDktMTQgMDg6MjE6MDkuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L3VzYi1saW51 eC5jCTIwMDgtMDktMTQgMDg6MjQ6NTYuMDAwMDAwMDAwICswMDAwCkBAIC0zNSwxMSArMzUsMjkg QEAKICNpbmNsdWRlIDxzeXMvaW9jdGwuaD4KICNpbmNsdWRlIDxzaWduYWwuaD4KIAotI2luY2x1 ZGUgPGxpbnV4L3VzYi9jaDkuaD4KICNpbmNsdWRlIDxsaW51eC91c2JkZXZpY2VfZnMuaD4KICNp bmNsdWRlIDxsaW51eC92ZXJzaW9uLmg+CiAjaW5jbHVkZSAiaHcvdXNiLmgiCiAKKy8qIFdlIHJl ZGVmaW5lIGl0IHRvIGF2b2lkIHZlcnNpb24gcHJvYmxlbXMgKi8KK3N0cnVjdCB1c2JfY3RybHRy YW5zZmVyIHsKKyAgICB1aW50OF90ICBiUmVxdWVzdFR5cGU7CisgICAgdWludDhfdCAgYlJlcXVl c3Q7CisgICAgdWludDE2X3Qgd1ZhbHVlOworICAgIHVpbnQxNl90IHdJbmRleDsKKyAgICB1aW50 MTZfdCB3TGVuZ3RoOworICAgIHVpbnQzMl90IHRpbWVvdXQ7CisgICAgdm9pZCAqZGF0YTsKK307 CisKK3N0cnVjdCB1c2JfY3RybHJlcXVlc3QgeworICAgIHVpbnQ4X3QgYlJlcXVlc3RUeXBlOwor ICAgIHVpbnQ4X3QgYlJlcXVlc3Q7CisgICAgdWludDE2X3Qgd1ZhbHVlOworICAgIHVpbnQxNl90 IHdJbmRleDsKKyAgICB1aW50MTZfdCB3TGVuZ3RoOworfTsKKwogdHlwZWRlZiBpbnQgVVNCU2Nh bkZ1bmModm9pZCAqb3BhcXVlLCBpbnQgYnVzX251bSwgaW50IGFkZHIsIGludCBjbGFzc19pZCwK ICAgICAgICAgICAgICAgICAgICAgICAgIGludCB2ZW5kb3JfaWQsIGludCBwcm9kdWN0X2lkLAog ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqcHJvZHVjdF9uYW1lLCBpbnQgc3Bl ZWQpOwpAQCAtNzEwLDcgKzcyOCw3IEBACiAgKgogICogUmV0dXJucyBsZW5ndGggb2YgdGhlIHRy YW5zYWN0aW9uIG9yIG9uZSBvZiB0aGUgVVNCX1JFVF9YWFggY29kZXMuCiAgKi8KLWludCB1c2Jf aG9zdF9oYW5kbGVfcGFja2V0KFVTQkRldmljZSAqcywgVVNCUGFja2V0ICpwKQorc3RhdGljIGlu dCB1c2JfaG9zdF9oYW5kbGVfcGFja2V0KFVTQkRldmljZSAqcywgVVNCUGFja2V0ICpwKQogewog ICAgIHN3aXRjaChwLT5waWQpIHsKICAgICBjYXNlIFVTQl9NU0dfQVRUQUNIOgo= ------=_Part_16905_16802799.1221381158827--