From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Ryan Harper <ryanh@us.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Refactor AIO to allow multiple AIO implementations
Date: Tue, 16 Sep 2008 20:50:27 +0300 [thread overview]
Message-ID: <f43fc5580809161050y384d37y61c53541ceba98db@mail.gmail.com> (raw)
In-Reply-To: <1221582247-8886-1-git-send-email-aliguori@us.ibm.com>
On 9/16/08, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This patch refactors the AIO layer to allow multiple AIO implementations. It's
> only possible because of the recent signalfd() patch.
> +/* This is a simple lock used to protect the aio_handlers list. Specifically,
> + * it's used to ensure that no callbacks are removed while we're walking and
> + * dispatching callbacks.
> + */
> +static int walking_handlers;
Shouldn't this be volatile and/or atomic_t?
Just wondering, why don't you use real locking operations, for example
those in qemu-lock.h?
next prev parent reply other threads:[~2008-09-16 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 16:24 [Qemu-devel] [PATCH] Refactor AIO to allow multiple AIO implementations Anthony Liguori
2008-09-16 17:50 ` Blue Swirl [this message]
2008-09-16 19:03 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580809161050y384d37y61c53541ceba98db@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).