From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KfgGU-0001aY-R9
	for qemu-devel@nongnu.org; Tue, 16 Sep 2008 15:31:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KfgGP-0001ZW-Jy
	for qemu-devel@nongnu.org; Tue, 16 Sep 2008 15:31:09 -0400
Received: from [199.232.76.173] (port=45993 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KfgGP-0001ZT-G0
	for qemu-devel@nongnu.org; Tue, 16 Sep 2008 15:31:05 -0400
Received: from an-out-0708.google.com ([209.85.132.240]:61698)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KfgGO-000287-Co
	for qemu-devel@nongnu.org; Tue, 16 Sep 2008 15:31:05 -0400
Received: by an-out-0708.google.com with SMTP id d18so406377and.130
	for <qemu-devel@nongnu.org>; Tue, 16 Sep 2008 12:31:01 -0700 (PDT)
Message-ID: <f43fc5580809161231y72baa935xe5b6a782daf08ffb@mail.gmail.com>
Date: Tue, 16 Sep 2008 22:31:01 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] env fields as TCG variables
In-Reply-To: <20080916191112.GA3992@edgar.se.axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f43fc5580809161137t819cb9ehd94b8c2be1b253@mail.gmail.com>
	<20080916191112.GA3992@edgar.se.axis.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 9/16/08, Edgar E. Iglesias <edgar.iglesias@axis.com> wrote:
> On Tue, Sep 16, 2008 at 09:37:41PM +0300, Blue Swirl wrote:
>  > I wonder if the following bug scenario is possible.
>  >
>  > Some of the env fields are accessible as TCG variables, like cpu_fsr
>  > for Sparc floating point status register (%fsr), stored in the env
>  > structure field env->fsr. When cpu_fsr is used in the generated code,
>  > a host CPU register is allocated for this task. But env->fsr can be
>  > modified directly in op_helper.c code. Isn't it then possible that the
>  > register (which stores cpu_fsr) and the structure field in memory
>  > (env->fsr) get out of sync?
>  >
>  > If this is true, no code outside the generated code should ever modify
>  > or even read env fields that are also available as TCG variables. Or
>  > do I miss something?
>
>
> Hello,
>
>  IIRC:
>  TCG writebacks before calling helpers. There used to be a bug with
>  qemu_ld/qemu_st like the one you described but it was fixed a long
>  time ago. I ran into that one with CRIS and avoided it for a while
>  by calling a dummy helper before load/stores.

OK, this solves the main part of the problem. But what about code
outside helpers, for example interrupt handling?