From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KgxDn-00046s-QI
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 03:49:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KgxDn-00046e-1Y
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 03:49:39 -0400
Received: from [199.232.76.173] (port=40607 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KgxDm-00046b-Qj
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 03:49:38 -0400
Received: from wf-out-1314.google.com ([209.85.200.173]:24803)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KgxDm-0000Zk-P6
	for qemu-devel@nongnu.org; Sat, 20 Sep 2008 03:49:39 -0400
Received: by wf-out-1314.google.com with SMTP id 27so857823wfd.4
	for <qemu-devel@nongnu.org>; Sat, 20 Sep 2008 00:49:36 -0700 (PDT)
Message-ID: <f43fc5580809200049q5d9cf8b5g8a5c46147f0aa9a0@mail.gmail.com>
Date: Sat, 20 Sep 2008 10:49:36 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] ld flag --warn-common
In-Reply-To: <20080919163730.GA5016@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f43fc5580809070124v10da89bcm109e771369400439@mail.gmail.com>
	<20080919163730.GA5016@localhost.localdomain>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 9/19/08, Kirill A. Shutemov <kirill@shutemov.name> wrote:
> On Sun, Sep 07, 2008 at 11:24:37AM +0300, Blue Swirl wrote:
>  > Hi,
>  >
>  > These trivial patches enable linker flag --warn-common and fix the
>  > warnings caused by enabling the flag.
>
>
> This flag cause a lot of warning on my machine, even with trivial program.
>
>  $ cat 1.c
>  #include <stdio.h>
>
>  int main()
>  {
>         printf("test\n");
>         return 0;
>  }
>  $ gcc -Wl,--warn-common -static 1.c
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtoul.o): warning: multiple common of `_nl_category_name_idxs'
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtol.o): warning: previous common is here
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtol_l.o): warning: multiple common of `_nl_category_name_idxs'
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtol.o): warning: previous common is here
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtoul_l.o): warning: multiple common of `_nl_category_name_idxs'
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtol.o): warning: previous common is here
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(vfprintf.o): warning: multiple common of `_nl_category_name_idxs'
>  /usr/lib64/gcc/x86_64-alt-linux/4.1.2/../../../../lib64/libc.a(strtol.o): warning: previous common is here
>
>  ...and so on.
>
>
>  Is it problem with my toolchain? What is your testing environment?

I get no warnings for Qemu build on Debian i386, amd64
(stable/unstable), Sparc32, Sparc64 or on OpenBSD/Sparc64. Your
program produces one warning on Debian stable (all hosts except no
warnings on arm), no warnings on Debian amd64 unstable or OpenBSD.