* [Qemu-devel] Two signalfd_compat threads created: remove one
@ 2008-09-20 14:12 Blue Swirl
2008-09-22 14:49 ` [Qemu-devel] " Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2008-09-20 14:12 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
Hi,
Function qemu_aio_init() is called from both vl.c and block.c. This
means that two threads handling signalfd_compat are created. This
patch removes the call from vl.c.
[-- Attachment #2: fix_aio_init.diff --]
[-- Type: plain/text, Size: 427 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: Two signalfd_compat threads created: remove one
2008-09-20 14:12 [Qemu-devel] Two signalfd_compat threads created: remove one Blue Swirl
@ 2008-09-22 14:49 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2008-09-22 14:49 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
Blue Swirl wrote:
> Hi,
>
> Function qemu_aio_init() is called from both vl.c and block.c. This
> means that two threads handling signalfd_compat are created. This
> patch removes the call from vl.c.
>
Thanks for catching this. I committed a slightly different patch. We
already go through the trouble of maintaining an aio_initialized
variable so I added a simple check to short-cut the aio_init function if
we've already been initialized. Your patch isn't necessary a bad one
though since it's already called from bdrv_init. Please commit.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-22 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-20 14:12 [Qemu-devel] Two signalfd_compat threads created: remove one Blue Swirl
2008-09-22 14:49 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).