From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KhSKW-0004wB-75 for qemu-devel@nongnu.org; Sun, 21 Sep 2008 13:02:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KhSKS-0004uB-P2 for qemu-devel@nongnu.org; Sun, 21 Sep 2008 13:02:39 -0400 Received: from [199.232.76.173] (port=47023 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KhSKS-0004u2-Kb for qemu-devel@nongnu.org; Sun, 21 Sep 2008 13:02:36 -0400 Received: from wf-out-1314.google.com ([209.85.200.175]:2596) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KhSKR-0002rx-QD for qemu-devel@nongnu.org; Sun, 21 Sep 2008 13:02:36 -0400 Received: by wf-out-1314.google.com with SMTP id 27so1242011wfd.4 for ; Sun, 21 Sep 2008 10:02:31 -0700 (PDT) Message-ID: Date: Sun, 21 Sep 2008 20:02:31 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [5281] Use the new concat_i32_i64 op for std and stda In-Reply-To: <200809211741.53544.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_67420_18921156.1222016551143" References: <200809211741.53544.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org ------=_Part_67420_18921156.1222016551143 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 9/21/08, Paul Brook wrote: > > Like these patches? > > > +static inline void tcg_gen_concat_i64_i64(TCGv dest, TCGv low, TCGv high) > > +{ > > + TCGv tmp = tcg_temp_new(TCG_TYPE_I64); > > + tcg_gen_shli_i64(tmp, high, 32); > > + tcg_gen_or_i64(dest, low, tmp); > > + tcg_temp_free(tmp); > > +} > > This should use concat_i32_i64 on 32-bit hosts. > > Ok with that change, the rename I suggested in my previous mail, and if you > add documentation to tcg/README. Updated. I'll run a couple of tests. ------=_Part_67420_18921156.1222016551143 Content-Type: plain/text; name=concat_ops.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fldx14fm Content-Disposition: attachment; filename=concat_ops.diff SW5kZXg6IHFlbXUvdGNnL3RjZy1vcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy90Y2cvdGNn LW9wLmgJMjAwOC0wOS0yMSAxNjoxODoyMi4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvdGNnL3Rj Zy1vcC5oCTIwMDgtMDktMjEgMTY6NTM6NDUuMDAwMDAwMDAwICswMDAwCkBAIC0xNDEyLDYgKzE0 MTIsMTggQEAKICNlbmRpZgogfQogCitzdGF0aWMgaW5saW5lIHZvaWQgdGNnX2dlbl9jb25jYXQz Ml9pNjQoVENHdiBkZXN0LCBUQ0d2IGxvdywgVENHdiBoaWdoKQoreworI2lmIFRDR19UQVJHRVRf UkVHX0JJVFMgPT0gMzIKKyAgICB0Y2dfZ2VuX2NvbmNhdF9pMzJfaTY0KGRlc3QsIGxvdywgaGln aCk7CisjZWxzZQorICAgIFRDR3YgdG1wID0gdGNnX3RlbXBfbmV3KFRDR19UWVBFX0k2NCk7Cisg ICAgdGNnX2dlbl9zaGxpX2k2NCh0bXAsIGhpZ2gsIDMyKTsKKyAgICB0Y2dfZ2VuX29yX2k2NChk ZXN0LCBsb3csIHRtcCk7CisgICAgdGNnX3RlbXBfZnJlZSh0bXApOworI2VuZGlmCit9CisKIC8q KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovCiAvKiBRRU1VIHNwZWNpZmlj IG9wZXJhdGlvbnMuIFRoZWlyIHR5cGUgZGVwZW5kIG9uIHRoZSBRRU1VIENQVQogICAgdHlwZS4g Ki8KQEAgLTE2NjQsNiArMTY3Niw3IEBACiAjZGVmaW5lIHRjZ19nZW5fZXh0MTZzX3RsIHRjZ19n ZW5fZXh0MTZzX2k2NAogI2RlZmluZSB0Y2dfZ2VuX2V4dDMydV90bCB0Y2dfZ2VuX2V4dDMydV9p NjQKICNkZWZpbmUgdGNnX2dlbl9leHQzMnNfdGwgdGNnX2dlbl9leHQzMnNfaTY0CisjZGVmaW5l IHRjZ19nZW5fY29uY2F0X3RsX2k2NCB0Y2dfZ2VuX2NvbmNhdDMyX2k2NAogI2RlZmluZSB0Y2df Y29uc3RfdGwgdGNnX2NvbnN0X2k2NAogI2Vsc2UKICNkZWZpbmUgVENHX1RZUEVfVEwgVENHX1RZ UEVfSTMyCkBAIC0xNzE1LDYgKzE3MjgsNyBAQAogI2RlZmluZSB0Y2dfZ2VuX2V4dDE2c190bCB0 Y2dfZ2VuX2V4dDE2c19pMzIKICNkZWZpbmUgdGNnX2dlbl9leHQzMnVfdGwgdGNnX2dlbl9tb3Zf aTMyCiAjZGVmaW5lIHRjZ19nZW5fZXh0MzJzX3RsIHRjZ19nZW5fbW92X2kzMgorI2RlZmluZSB0 Y2dfZ2VuX2NvbmNhdF90bF9pNjQgdGNnX2dlbl9jb25jYXRfaTMyX2k2NAogI2RlZmluZSB0Y2df Y29uc3RfdGwgdGNnX2NvbnN0X2kzMgogI2VuZGlmCiAKSW5kZXg6IHFlbXUvdGNnL1JFQURNRQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvdGNnL1JFQURNRQkyMDA4LTA5LTIxIDE2OjU0OjM5LjAw MDAwMDAwMCArMDAwMAorKysgcWVtdS90Y2cvUkVBRE1FCTIwMDgtMDktMjEgMTY6NTU6NTguMDAw MDAwMDAwICswMDAwCkBAIC0yNjksNiArMjY5LDEwIEBACiBDb25zdHJ1Y3QgdDAgKDY0LWJpdCkg dGFraW5nIHRoZSBsb3cgaGFsZiBmcm9tIHQxICgzMiBiaXQpIGFuZCB0aGUgaGlnaCBoYWxmCiBm cm9tIHQyICgzMiBiaXQpLgogCisqIGNvbmNhdDMyX2k2NCB0MCwgdDEsIHQyCitDb25zdHJ1Y3Qg dDAgKDY0LWJpdCkgdGFraW5nIHRoZSBsb3cgaGFsZiBmcm9tIHQxICg2NCBiaXQpIGFuZCB0aGUg aGlnaCBoYWxmCitmcm9tIHQyICg2NCBiaXQpLgorCiAqKioqKioqKiogTG9hZC9TdG9yZQogCiAq IGxkX2kzMi9pNjQgdDAsIHQxLCBvZmZzZXQK ------=_Part_67420_18921156.1222016551143 Content-Type: plain/text; name=use_concat_ops.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fldx1lox Content-Disposition: attachment; filename=use_concat_ops.diff SW5kZXg6IHFlbXUvdGFyZ2V0LXNwYXJjL3RyYW5zbGF0ZS5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUu b3JpZy90YXJnZXQtc3BhcmMvdHJhbnNsYXRlLmMJMjAwOC0wOS0yMSAxNjoyMTo1My4wMDAwMDAw MDAgKzAwMDAKKysrIHFlbXUvdGFyZ2V0LXNwYXJjL3RyYW5zbGF0ZS5jCTIwMDgtMDktMjEgMTY6 Mjc6MDYuMDAwMDAwMDAwICswMDAwCkBAIC0xNzE1LDE0ICsxNzE1LDEwIEBACiAKIHN0YXRpYyBp bmxpbmUgdm9pZCBnZW5fc3RkYV9hc2koVENHdiBoaSwgVENHdiBhZGRyLCBpbnQgaW5zbiwgaW50 IHJkKQogewotICAgIFRDR3Ygcl9sb3csIHJfYXNpLCByX3NpemU7CisgICAgVENHdiByX2FzaSwg cl9zaXplOwogCiAgICAgZ2VuX21vdmxfcmVnX1ROKHJkICsgMSwgY3B1X3RtcDApOwotICAgIHJf bG93ID0gdGNnX3RlbXBfbmV3KFRDR19UWVBFX0kzMik7Ci0gICAgdGNnX2dlbl90cnVuY190bF9p MzIocl9sb3csIGNwdV90bXAwKTsKLSAgICB0Y2dfZ2VuX3RydW5jX3RsX2kzMihjcHVfdG1wMzIs IGhpKTsKLSAgICB0Y2dfZ2VuX2NvbmNhdF9pMzJfaTY0KGNwdV90bXA2NCwgcl9sb3csIGNwdV90 bXAzMik7Ci0gICAgdGNnX3RlbXBfZnJlZShyX2xvdyk7CisgICAgdGNnX2dlbl9jb25jYXRfdGxf aTY0KGNwdV90bXA2NCwgY3B1X3RtcDAsIGhpKTsKICAgICByX2FzaSA9IGdlbl9nZXRfYXNpKGlu c24sIGFkZHIpOwogICAgIHJfc2l6ZSA9IHRjZ19jb25zdF9pMzIoOCk7CiAgICAgdGNnX2dlbl9o ZWxwZXJfMF80KGhlbHBlcl9zdF9hc2ksIGFkZHIsIGNwdV90bXA2NCwgcl9hc2ksIHJfc2l6ZSk7 CkBAIC0xODE4LDE0ICsxODE0LDEwIEBACiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBnZW5fc3RkYV9h c2koVENHdiBoaSwgVENHdiBhZGRyLCBpbnQgaW5zbiwgaW50IHJkKQogewotICAgIFRDR3Ygcl9s b3csIHJfYXNpLCByX3NpemU7CisgICAgVENHdiByX2FzaSwgcl9zaXplOwogCiAgICAgZ2VuX21v dmxfcmVnX1ROKHJkICsgMSwgY3B1X3RtcDApOwotICAgIHJfbG93ID0gdGNnX3RlbXBfbmV3KFRD R19UWVBFX0kzMik7Ci0gICAgdGNnX2dlbl90cnVuY190bF9pMzIocl9sb3csIGNwdV90bXAwKTsK LSAgICB0Y2dfZ2VuX3RydW5jX3RsX2kzMihjcHVfdG1wMzIsIGhpKTsKLSAgICB0Y2dfZ2VuX2Nv bmNhdF9pMzJfaTY0KGNwdV90bXA2NCwgcl9sb3csIGNwdV90bXAzMik7Ci0gICAgdGNnX3RlbXBf ZnJlZShyX2xvdyk7CisgICAgdGNnX2dlbl9jb25jYXRfdGxfaTY0KGNwdV90bXA2NCwgY3B1X3Rt cDAsIGhpKTsKICAgICByX2FzaSA9IHRjZ19jb25zdF9pMzIoR0VUX0ZJRUxEKGluc24sIDE5LCAy NikpOwogICAgIHJfc2l6ZSA9IHRjZ19jb25zdF9pMzIoOCk7CiAgICAgdGNnX2dlbl9oZWxwZXJf MF80KGhlbHBlcl9zdF9hc2ksIGFkZHIsIGNwdV90bXA2NCwgcl9hc2ksIHJfc2l6ZSk7CkBAIC00 NDc3LDcgKzQ0NjksNyBAQAogICAgICAgICAgICAgICAgICAgICBpZiAocmQgJiAxKQogICAgICAg ICAgICAgICAgICAgICAgICAgZ290byBpbGxlZ2FsX2luc247CiAgICAgICAgICAgICAgICAgICAg IGVsc2UgewotICAgICAgICAgICAgICAgICAgICAgICAgVENHdiByX2xvdywgcl9jb25zdDsKKyAg ICAgICAgICAgICAgICAgICAgICAgIFRDR3Ygcl9jb25zdDsKIAogICAgICAgICAgICAgICAgICAg ICAgICAgc2F2ZV9zdGF0ZShkYywgY3B1X2NvbmQpOwogICAgICAgICAgICAgICAgICAgICAgICAg Z2VuX2FkZHJlc3NfbWFzayhkYywgY3B1X2FkZHIpOwpAQCAtNDQ4NiwxMSArNDQ3OCw3IEBACiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcl9jb25zdCk7IC8vIFhY WCByZW1vdmUKICAgICAgICAgICAgICAgICAgICAgICAgIHRjZ190ZW1wX2ZyZWUocl9jb25zdCk7 CiAgICAgICAgICAgICAgICAgICAgICAgICBnZW5fbW92bF9yZWdfVE4ocmQgKyAxLCBjcHVfdG1w MCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICByX2xvdyA9IHRjZ190ZW1wX25ldyhUQ0dfVFlQ RV9JMzIpOwotICAgICAgICAgICAgICAgICAgICAgICAgdGNnX2dlbl90cnVuY190bF9pMzIocl9s b3csIGNwdV90bXAwKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRjZ19nZW5fdHJ1bmNfdGxf aTMyKGNwdV90bXAzMiwgY3B1X3ZhbCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICB0Y2dfZ2Vu X2NvbmNhdF9pMzJfaTY0KGNwdV90bXA2NCwgcl9sb3csIGNwdV90bXAzMik7Ci0gICAgICAgICAg ICAgICAgICAgICAgICB0Y2dfdGVtcF9mcmVlKHJfbG93KTsKKyAgICAgICAgICAgICAgICAgICAg ICAgIHRjZ19nZW5fY29uY2F0X2kzMl9pNjQoY3B1X3RtcDY0LCBjcHVfdG1wMCwgY3B1X3ZhbCk7 CiAgICAgICAgICAgICAgICAgICAgICAgICB0Y2dfZ2VuX3FlbXVfc3Q2NChjcHVfdG1wNjQsIGNw dV9hZGRyLCBkYy0+bWVtX2lkeCk7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7Cg== ------=_Part_67420_18921156.1222016551143--