From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kho8x-0000Fz-Jl for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:20:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kho8v-0000Cw-N7 for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:20:10 -0400 Received: from [199.232.76.173] (port=56496 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kho8v-0000Cc-IF for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:20:09 -0400 Received: from rn-out-0910.google.com ([64.233.170.188]:29091) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kho8u-0003Zm-Ln for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:20:08 -0400 Received: by rn-out-0910.google.com with SMTP id m61so1060608rnd.8 for ; Mon, 22 Sep 2008 09:20:08 -0700 (PDT) Message-ID: Date: Mon, 22 Sep 2008 19:20:07 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] sparc64 reverse cas and casx arguments In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 9/21/08, Igor Kovalenko wrote: > Hi! > > The following patch should fix a problem with sparc64 cas and casx > emulation where value to be stored and value to be compared are passed > in reverse order to helper function. > > This also fixes a problem with booting linux iso where kernel tries to > clear memory bitmap bit with casx but fails to find any cleared bit > later. > > Please apply. Thanks for spotting. I think a cleaner solution would be to rearrange the code so that the argument names match the instruction field names. > PS: if anyone can send me a patch for gdb to load and use System.map > file while doing remote debugging that would be great :) I have usually compiled the kernel with -g flag and then used the vmlinux file when debugging.