From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KivsK-00039h-Ko
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 14:47:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KivsJ-00039O-2o
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 14:47:40 -0400
Received: from [199.232.76.173] (port=54341 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KivsI-00039L-Tr
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 14:47:38 -0400
Received: from wf-out-1314.google.com ([209.85.200.168]:21113)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KivsJ-00068H-0v
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 14:47:39 -0400
Received: by wf-out-1314.google.com with SMTP id 27so631498wfd.4
	for <qemu-devel@nongnu.org>; Thu, 25 Sep 2008 11:47:37 -0700 (PDT)
Message-ID: <f43fc5580809251147u4c942a2cma004c404c63fce0f@mail.gmail.com>
Date: Thu, 25 Sep 2008 21:47:37 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [5274] Add signed versions of save/load functions
In-Reply-To: <48DBD707.4040806@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KgxRs-0002UK-Ch@cvs.savannah.gnu.org>
	<48DBD707.4040806@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 9/25/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Revision: 5274
> >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5274
> > Author:   blueswir1
> > Date:     2008-09-20 08:04:11 +0000 (Sat, 20 Sep 2008)
> >
> >
>
>  Hi Blue Swirl,
>
>  I just noticed save/restore is broken for target-i386 and I bisected to
> this commit.  I'm going to start looking into what's broken but wanted to
> let you know in case you had an idea.

Strange, I have now looked through the patch two times and still find
nothing very suspicious (maybe except for int -> size_t change, but
that should not affect saved data).

Maybe the problem is in the calling side outside of the patched code.
Do you happen to know which device is broken?