From: "Blue Swirl" <blauwirbel@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5274] Add signed versions of save/load functions
Date: Fri, 26 Sep 2008 00:14:36 +0300 [thread overview]
Message-ID: <f43fc5580809251414p2c5e5c83v320d72a4bba20e79@mail.gmail.com> (raw)
In-Reply-To: <48DBF274.5000005@codemonkey.ws>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On 9/25/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Right. I think the patch should be split into three operations: signed
> > version addition, int to size_t change and this dangerous type size
> > change. Only the first one is obviously correct, which I thought all
> > of these changes were.
> >
> > Thanks for debugging, I'll revert this patch and make new patches for
> review.
> >
> >
>
> Thanks!
I split the patch into three pieces. The signed API patch should be
safe, two others need more careful review and testing.
[-- Attachment #2: signed_savevm_api.diff --]
[-- Type: plain/text, Size: 15599 bytes --]
[-- Attachment #3: use_size_t.diff --]
[-- Type: plain/text, Size: 2266 bytes --]
[-- Attachment #4: buggy_use_more_accurate_types.diff --]
[-- Type: plain/text, Size: 3862 bytes --]
prev parent reply other threads:[~2008-09-25 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 8:04 [Qemu-devel] [5274] Add signed versions of save/load functions Blue Swirl
2008-09-25 18:23 ` Anthony Liguori
2008-09-25 18:47 ` Blue Swirl
2008-09-25 19:59 ` Anthony Liguori
2008-09-25 20:17 ` Blue Swirl
2008-09-25 20:20 ` Anthony Liguori
2008-09-25 21:14 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580809251414p2c5e5c83v320d72a4bba20e79@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).