qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5335] Change the way video graphics adapter is selected
Date: Sun, 28 Sep 2008 18:46:20 +0300	[thread overview]
Message-ID: <f43fc5580809280846r195ab4e6r6ca72c1b586e636e@mail.gmail.com> (raw)
In-Reply-To: <48DF97F0.4010802@codemonkey.ws>

On 9/28/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > On 9/28/08, malc <av1474@comtv.ru> wrote:
> >
> >
> > > Revision: 5335
> > >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5335
> > >  Author:   malc
> > >  Date:     2008-09-28 00:42:05 +0000 (Sun, 28 Sep 2008)
> > >
> > >  Log Message:
> > >  -----------
> > >  Change the way video graphics adapter is selected
> > >
> > >  Instead of having (current)three command line switches -std-vga,
> > >  -cirrusvga and -vmwarevga, provide one -vga switch which takes
> > >  an argument, so that:
> > >  qemu -std-vga   becomes qemu -vga std
> > >  qemu -cirrusvga becomes qemu -vga cirrus
> > >  qemu -vmwarevga becomes qemu -vga vmware
> > >
> > >
> >
> > I'd prefer a more generic syntax, like -drive options:
> > -displayhw model=vga,type=std
> > -displayhw model=vga,type=std
> > -displayhw model=vga,type=std
> > -displayhw model=tcx,type=hardwarecursor
> >
> >
>
>  I think this would quickly rat hole since it requires rewriting a huge
> amount of code.

I forgot to change the copied part, I meant to write:
-displayhw model=vga,type=std
-displayhw model=vga,type=cirrrus
-displayhw model=vga,type=vmware
-displayhw model=tcx,type=hardwarecursor

These options should be (for now) mutually exclusive, so you could
select only one. I think the code changes would be limited to vl.c,
with similar parsing to what is done for -drive. The devices would not
be changed at this stage. I can't see how this would become any mess,
what problems you foresee?

> > Then this option would be useful for non-VGA targets. I don't see -vga
> > xxx as an improvement over -xxx-vga.
> >
> >
>
>  If the next steps are creating a mechanism to register VGA hw emulation,
> then I think this is a step in the right direction.
>
>  I think we have to get to a place where most hardware devices are
> registered within a generic frame work before we start trying to expose that
> to the user.

Maybe. It would be great to get a config file.

  reply	other threads:[~2008-09-28 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-28  0:42 [Qemu-devel] [5335] Change the way video graphics adapter is selected malc
2008-09-28  6:01 ` Blue Swirl
2008-09-28 14:42   ` Anthony Liguori
2008-09-28 15:46     ` Blue Swirl [this message]
2008-09-28 14:57   ` andrzej zaborowski
2008-09-28 15:55     ` Blue Swirl
2008-09-28 18:47       ` andrzej zaborowski
2008-09-28 18:09   ` malc
2008-09-28 14:41 ` Anthony Liguori
2008-09-29  9:38 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580809280846r195ab4e6r6ca72c1b586e636e@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).