From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KjyTZ-0008Hd-9l for qemu-devel@nongnu.org; Sun, 28 Sep 2008 11:46:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KjyTX-0008Gz-EM for qemu-devel@nongnu.org; Sun, 28 Sep 2008 11:46:24 -0400 Received: from [199.232.76.173] (port=50723 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KjyTX-0008Gu-8g for qemu-devel@nongnu.org; Sun, 28 Sep 2008 11:46:23 -0400 Received: from wf-out-1314.google.com ([209.85.200.174]:46405) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KjyTX-0000W1-0o for qemu-devel@nongnu.org; Sun, 28 Sep 2008 11:46:23 -0400 Received: by wf-out-1314.google.com with SMTP id 27so1772358wfd.4 for ; Sun, 28 Sep 2008 08:46:21 -0700 (PDT) Message-ID: Date: Sun, 28 Sep 2008 18:46:20 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [5335] Change the way video graphics adapter is selected In-Reply-To: <48DF97F0.4010802@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48DF97F0.4010802@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 9/28/08, Anthony Liguori wrote: > Blue Swirl wrote: > > > On 9/28/08, malc wrote: > > > > > > > Revision: 5335 > > > > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5335 > > > Author: malc > > > Date: 2008-09-28 00:42:05 +0000 (Sun, 28 Sep 2008) > > > > > > Log Message: > > > ----------- > > > Change the way video graphics adapter is selected > > > > > > Instead of having (current)three command line switches -std-vga, > > > -cirrusvga and -vmwarevga, provide one -vga switch which takes > > > an argument, so that: > > > qemu -std-vga becomes qemu -vga std > > > qemu -cirrusvga becomes qemu -vga cirrus > > > qemu -vmwarevga becomes qemu -vga vmware > > > > > > > > > > I'd prefer a more generic syntax, like -drive options: > > -displayhw model=vga,type=std > > -displayhw model=vga,type=std > > -displayhw model=vga,type=std > > -displayhw model=tcx,type=hardwarecursor > > > > > > I think this would quickly rat hole since it requires rewriting a huge > amount of code. I forgot to change the copied part, I meant to write: -displayhw model=vga,type=std -displayhw model=vga,type=cirrrus -displayhw model=vga,type=vmware -displayhw model=tcx,type=hardwarecursor These options should be (for now) mutually exclusive, so you could select only one. I think the code changes would be limited to vl.c, with similar parsing to what is done for -drive. The devices would not be changed at this stage. I can't see how this would become any mess, what problems you foresee? > > Then this option would be useful for non-VGA targets. I don't see -vga > > xxx as an improvement over -xxx-vga. > > > > > > If the next steps are creating a mechanism to register VGA hw emulation, > then I think this is a step in the right direction. > > I think we have to get to a place where most hardware devices are > registered within a generic frame work before we start trying to expose that > to the user. Maybe. It would be great to get a config file.