From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KlSWE-00041Q-Lf for qemu-devel@nongnu.org; Thu, 02 Oct 2008 14:03:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KlSWD-000418-8A for qemu-devel@nongnu.org; Thu, 02 Oct 2008 14:03:18 -0400 Received: from [199.232.76.173] (port=57604 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KlSWD-000414-4t for qemu-devel@nongnu.org; Thu, 02 Oct 2008 14:03:17 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:49359) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KlSWC-0005hX-El for qemu-devel@nongnu.org; Thu, 02 Oct 2008 14:03:16 -0400 Received: by gxk12 with SMTP id 12so1860118gxk.10 for ; Thu, 02 Oct 2008 11:02:57 -0700 (PDT) Message-ID: Date: Thu, 2 Oct 2008 21:02:56 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses In-Reply-To: <48E430EB.5020202@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48E430EB.5020202@earthlink.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 10/2/08, Robert Reif wrote: > #ifdef TARGET_SPARC > + do_unassigned_access(addr, 0, 0, 0, 1); > +#elif defined(TARGET_CRIS) > do_unassigned_access(addr, 0, 0, 0); > +#endif > + return 0; I think it would be cleaner solution to convert also CRIS and MIPS versions to take the size argument.