From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] USB over network
Date: Mon, 6 Oct 2008 18:05:40 +0300 [thread overview]
Message-ID: <f43fc5580810060805x530768f1ie6258732aa217024@mail.gmail.com> (raw)
In-Reply-To: <ED2414DB5FBBCF4FA66ECE71F290E9A2B601E6@EXVBE011-2.exch011.intermedia.net>
On 10/6/08, Gal Hammer <gal@qumranet.com> wrote:
> Attached is a preliminary patch which add QEmu the ability to use local USB
> devices over network. It should work with DOK devices and might work with
> web cameras.
How about USB drives or printers, do they work?
A few comments:
- 'static' can be applied to a lot of functions
- instead of including linux/usb_ch9.h, you should define the
structures, like in usb-linux.c
- while the daemon is linux specific, the remote protocol looks like
host OS neutral, so it should not be too tightly tied to usb-linux.c
- name __ioctl looks like it could clash with system defines and it's
not very descriptive
- USB_REMOTE_MAGIC is not endian neutral, or is that the purpose?
- upper-case structure names are IMHO ugly
Otherwise, great idea!
next prev parent reply other threads:[~2008-10-06 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 11:43 [Qemu-devel] [PATCH] USB over network Gal Hammer
2008-10-06 12:09 ` Paul Brook
2008-10-06 12:22 ` Paul Brook
2008-10-06 12:42 ` Dor Laor
2008-10-06 13:15 ` Gal Hammer
2008-10-06 13:32 ` Paul Brook
2008-10-06 13:41 ` Anthony Liguori
2008-10-06 14:20 ` Gal Hammer
2008-10-06 15:24 ` Alexander Graf
2008-10-06 12:32 ` Daniel P. Berrange
2008-10-06 15:05 ` Blue Swirl [this message]
2008-10-07 8:34 ` Gal Hammer
2008-10-07 18:08 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810060805x530768f1ie6258732aa217024@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).