From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmreb-0005Ym-5d for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:05:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KmreY-0005Y9-GO for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:05:43 -0400 Received: from [199.232.76.173] (port=59066 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KmreY-0005Y6-DJ for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:05:42 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:45124) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KmreX-00025s-T9 for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:05:42 -0400 Received: by gxk12 with SMTP id 12so5621461gxk.10 for ; Mon, 06 Oct 2008 08:05:40 -0700 (PDT) Message-ID: Date: Mon, 6 Oct 2008 18:05:40 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] USB over network In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 10/6/08, Gal Hammer wrote: > Attached is a preliminary patch which add QEmu the ability to use local USB > devices over network. It should work with DOK devices and might work with > web cameras. How about USB drives or printers, do they work? A few comments: - 'static' can be applied to a lot of functions - instead of including linux/usb_ch9.h, you should define the structures, like in usb-linux.c - while the daemon is linux specific, the remote protocol looks like host OS neutral, so it should not be too tightly tied to usb-linux.c - name __ioctl looks like it could clash with system defines and it's not very descriptive - USB_REMOTE_MAGIC is not endian neutral, or is that the purpose? - upper-case structure names are IMHO ugly Otherwise, great idea!