From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KmsRW-0006Rd-UA
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:56:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KmsRU-0006RR-Hc
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:56:17 -0400
Received: from [199.232.76.173] (port=42264 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KmsRU-0006RO-B2
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:56:16 -0400
Received: from rn-out-0910.google.com ([64.233.170.186]:63940)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KmsRU-00071Y-3Y
	for qemu-devel@nongnu.org; Mon, 06 Oct 2008 11:56:16 -0400
Received: by rn-out-0910.google.com with SMTP id m61so2127408rnd.8
	for <qemu-devel@nongnu.org>; Mon, 06 Oct 2008 08:56:15 -0700 (PDT)
Message-ID: <f43fc5580810060856v4859fb00y94799056cf72e143@mail.gmail.com>
Date: Mon, 6 Oct 2008 18:56:14 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses
In-Reply-To: <48E9A000.7040808@earthlink.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <48E430EB.5020202@earthlink.net>
	<f43fc5580810021102m44e41889g5f42c9b79bd67698@mail.gmail.com>
	<48E9A000.7040808@earthlink.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 10/6/08, Robert Reif <reif@earthlink.net> wrote:
> Blue Swirl wrote:
>
> > On 10/2/08, Robert Reif <reif@earthlink.net> wrote:
> >
> >
> > >  #ifdef TARGET_SPARC
> > >  +    do_unassigned_access(addr, 0, 0, 0, 1);
> > >  +#elif defined(TARGET_CRIS)
> > >     do_unassigned_access(addr, 0, 0, 0);
> > >  +#endif
> > >  +    return 0;
> > >
> > >
> >
> > I think it would be cleaner solution to convert also CRIS and MIPS
> > versions to take the size argument.

Is this patch OK for CRIS and MIPS too? The extra parameter should not hurt.