From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Optimize ld[bwlq]_phys and st[bwlq]_phys
Date: Mon, 20 Oct 2008 19:36:52 +0300 [thread overview]
Message-ID: <f43fc5580810200936q1631fa61t1c4bf4e651f021a4@mail.gmail.com> (raw)
In-Reply-To: <1224014348-13765-1-git-send-email-aliguori@us.ibm.com>
On 10/14/08, Anthony Liguori <aliguori@us.ibm.com> wrote:
> This patch optimizes the ld and st functions that operate on physical addresses.
> Right now, a number of them default to cpu_phys_memory_{read,write} which is
> very slow. As long as the operations are aligned, it is safe to just lookup
> the page and directly read/write the data via ld_p or st_p.
>
> This patch introduces a common function since all of these functions are
> roughly the same. I've tested x86 and sparc with Linux and Windows guests.
>
> I'm pretty confident that this new code is functionally equivalent but I wanted
> to have someone else confirm this.
Why there are special cases for lduw and stw?
I'd add 'inline' to the common functions, otherwise looks OK.
next prev parent reply other threads:[~2008-10-20 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 19:59 [Qemu-devel] [PATCH][RFC] Optimize ld[bwlq]_phys and st[bwlq]_phys Anthony Liguori
2008-10-20 16:36 ` Blue Swirl [this message]
2008-10-21 13:37 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810200936q1631fa61t1c4bf4e651f021a4@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).