From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] MIPS: DMA support for RC4030 chipset
Date: Mon, 20 Oct 2008 20:50:18 +0300 [thread overview]
Message-ID: <f43fc5580810201050m1378d738i7aee64a439009a55@mail.gmail.com> (raw)
In-Reply-To: <48FB9246.4030708@reactos.org>
On 10/19/08, Hervé Poussineau <hpoussin@reactos.org> wrote:
> Hi,
>
> Attached patch implements DMA support to RC4030 chipset and simplifies jazz
> IO part (at 0xf0000000), where registers contain 16 bit values.
> The patch also wires DMA for the SCSI adapter in the Jazz emulation (Mips
> Magnum 4000 and Acer Pica 61).
I'd move espdma_memory_read & write to rc4030.c, that way the opaque
passed to esp_init could be directly rc4030State type.
Allocating a new dma_table every time the table changes seems
wasteful, you could read the entry from memory as needed.
prev parent reply other threads:[~2008-10-20 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 20:02 [Qemu-devel] [PATCH] MIPS: DMA support for RC4030 chipset Hervé Poussineau
2008-10-20 17:50 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810201050m1378d738i7aee64a439009a55@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).