From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Move some declarations around in the QEMU CharDriver code
Date: Fri, 24 Oct 2008 17:12:13 +0300 [thread overview]
Message-ID: <f43fc5580810240712g73a2d6a5ue8959ce94f76a270@mail.gmail.com> (raw)
In-Reply-To: <1224790775-14106-1-git-send-email-aliguori@us.ibm.com>
On 10/23/08, Anthony Liguori <aliguori@us.ibm.com> wrote:
> The goal of this series is to move the CharDriverState code out of vl.c and
> into its own file, qemu-char.c. This patch moves around some declarations so
> the next patch can be pure code motion.
Good idea. Do you plan to do this for other things, for example network code?
> -static inline int send_all(int fd, const uint8_t *buf, int len1)
> +inline int send_all(int fd, const uint8_t *buf, int len1)
The 'inline' looks a bit odd without 'static'.
next prev parent reply other threads:[~2008-10-24 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 19:39 [Qemu-devel] [PATCH 1/2] Move some declarations around in the QEMU CharDriver code Anthony Liguori
2008-10-23 19:39 ` [Qemu-devel] [PATCH 2/2] Move CharDriverState code out of vl.c Anthony Liguori
2008-10-24 14:12 ` Blue Swirl [this message]
2008-10-24 14:18 ` [Qemu-devel] [PATCH 1/2] Move some declarations around in the QEMU CharDriver code Gerd Hoffmann
2008-10-27 20:48 ` Anthony Liguori
2008-10-27 20:46 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810240712g73a2d6a5ue8959ce94f76a270@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).