From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KtNOj-0005pb-T7
	for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:12:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KtNOh-0005of-NY
	for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:12:16 -0400
Received: from [199.232.76.173] (port=56517 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KtNOh-0005ob-KU
	for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:12:15 -0400
Received: from el-out-1112.google.com ([209.85.162.179]:35875)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KtNOh-0007u4-NS
	for qemu-devel@nongnu.org; Fri, 24 Oct 2008 10:12:15 -0400
Received: by el-out-1112.google.com with SMTP id s27so386205ele.19
	for <qemu-devel@nongnu.org>; Fri, 24 Oct 2008 07:12:14 -0700 (PDT)
Message-ID: <f43fc5580810240712g73a2d6a5ue8959ce94f76a270@mail.gmail.com>
Date: Fri, 24 Oct 2008 17:12:13 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Move some declarations around in the
	QEMU CharDriver code
In-Reply-To: <1224790775-14106-1-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1224790775-14106-1-git-send-email-aliguori@us.ibm.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 10/23/08, Anthony Liguori <aliguori@us.ibm.com> wrote:
> The goal of this series is to move the CharDriverState code out of vl.c and
>  into its own file, qemu-char.c.  This patch moves around some declarations so
>  the next patch can be pure code motion.

Good idea. Do you plan to do this for other things, for example network code?

>  -static inline int send_all(int fd, const uint8_t *buf, int len1)
>  +inline int send_all(int fd, const uint8_t *buf, int len1)

The 'inline' looks a bit odd without 'static'.