From: "Blue Swirl" <blauwirbel@gmail.com>
To: Juergen Lock <nox@jelal.kn-bremen.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD
Date: Sun, 26 Oct 2008 11:52:28 +0200 [thread overview]
Message-ID: <f43fc5580810260252y6f418b59pb992d419dca1472a@mail.gmail.com> (raw)
In-Reply-To: <200810252114.m9PLEqUW077079@saturn.kn-bremen.de>
On 10/25/08, Juergen Lock <nox@jelal.kn-bremen.de> wrote:
> Hi!
>
>
> In article <E1KthAo-0006G1-Pq@cvs.savannah.gnu.org> you write:
> >Revision: 5530
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5530
> >Author: blueswir1
> >Date: 2008-10-25 11:19:14 +0000 (Sat, 25 Oct 2008)
> >
> >Log Message:
> >-----------
> >Fix undefined pthread_sigmask warning on OpenBSD
> >
> >Modified Paths:
> >--------------
> > trunk/audio/sdlaudio.c
> >
> >Modified: trunk/audio/sdlaudio.c
> >===================================================================
> >--- trunk/audio/sdlaudio.c 2008-10-25 11:18:12 UTC (rev 5529)
> >+++ trunk/audio/sdlaudio.c 2008-10-25 11:19:14 UTC (rev 5530)
> >@@ -29,6 +29,8 @@
> > #ifndef _WIN32
> > #ifdef __sun__
> > #define _POSIX_PTHREAD_SEMANTICS 1
> >+#elif defined(__OpenBSD__)
> >+#include <pthread.h>
> > #endif
> > #include <signal.h>
> > #endif
> >
>
> I forgot to mention that I also patched this for FreeBSD, so the above
>
> >+#elif defined(__OpenBSD__)
>
> can be changed to
>
> >+#elif defined(__OpenBSD__) || defined(__FreeBSD__)
>
> Or do I need to send a proper patch? :)
No, I'll just copy and paste. It looks like NetBSD uses signal.h like
everyone should.
http://www.opengroup.org/onlinepubs/009695399/functions/pthread_sigmask.html
http://cvsweb.netbsd.org/bsdweb.cgi/src/include/signal.h?rev=1.50&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
prev parent reply other threads:[~2008-10-26 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 11:19 [Qemu-devel] [5530] Fix undefined pthread_sigmask warning on OpenBSD Blue Swirl
2008-10-25 21:14 ` Juergen Lock
2008-10-26 9:52 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810260252y6f418b59pb992d419dca1472a@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=nox@jelal.kn-bremen.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).