From: "Blue Swirl" <blauwirbel@gmail.com>
To: "takasi-y@ops.dti.ne.jp" <takasi-y@ops.dti.ne.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] sh4: mmio based CF support on r2d board.
Date: Mon, 27 Oct 2008 21:12:53 +0200 [thread overview]
Message-ID: <f43fc5580810271212p71ee1461v1e78d282beead85b@mail.gmail.com> (raw)
In-Reply-To: <200810271857.m9RIvW14029178@smtp12.dti.ne.jp>
On 10/27/08, takasi-y@ops.dti.ne.jp <takasi-y@ops.dti.ne.jp> wrote:
> > This should be in a .h file (maybe pc.h), without "extern" and the
> > parameter names should be included.
>
> Sure. But, I wonder which file is suitable.
> The system I accustomed to is like
> - ide.c define function
> - ide.h declare prototype
> - pc.c include ide.h and refer the function.
> But in QEMU, it looks like
> - ide.c define function
> - pc.h declare prototype
> - pc.c include pc.h and refer the function.
I agree that the current .h system is not clear, I would prefer the
system you described. The reason is that otherwise there would be a
lot of files, many with just one function for device init.
> Is it mean the prototype declaration should go into new file "r2d.h" ?
How about sh.h? It's already included from r2d.c.
next prev parent reply other threads:[~2008-10-27 19:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 16:31 [Qemu-devel] [PATCH] sh4: mmio based CF support on r2d board yoshii.takashi
2008-09-22 19:00 ` takasi-y
2008-09-23 8:55 ` Paul Mundt
2008-10-08 15:20 ` pmac kernel & disk image wanted (was Re: [Qemu-devel] [PATCH] sh4: mmio based CF support on r2d board.) Shin-ichiro KAWASAKI
2008-10-26 15:35 ` Andreas Färber
2008-10-26 15:17 ` [Qemu-devel] [PATCH 1/3] sh4: mmio based CF support on r2d board takasi-y
2008-10-26 15:54 ` Blue Swirl
2008-10-27 1:29 ` andrzej zaborowski
2008-10-27 17:10 ` Blue Swirl
2008-10-29 14:22 ` andrzej zaborowski
2008-10-29 18:37 ` Blue Swirl
2008-10-27 18:57 ` takasi-y
2008-10-27 19:12 ` Blue Swirl [this message]
2008-10-28 20:58 ` [Qemu-devel] [PATCH 1/3] take3 " takasi-y
2008-10-26 15:17 ` [Qemu-devel] [PATCH 0/3] take 2. " takasi-y
2008-10-26 15:17 ` [Qemu-devel] [PATCH 2/3] sh4: Add IRL(4bit encoded interrupt input) support takasi-y
2008-10-26 16:09 ` Blue Swirl
2008-10-28 20:58 ` [Qemu-devel] [PATCH 2/3] take3 " takasi-y
2008-10-29 18:09 ` [Qemu-devel] " Blue Swirl
2008-10-30 17:28 ` takasi-y
2008-10-26 15:17 ` [Qemu-devel] [PATCH 3/3] sh4: Add r2d onboard FPGA IRQ controller takasi-y
2008-10-28 20:58 ` [Qemu-devel] [PATCH 3/3] take3 " takasi-y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580810271212p71ee1461v1e78d282beead85b@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=takasi-y@ops.dti.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).