From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KuXWO-0004Lk-G0
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 15:13:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KuXWN-0004L8-0M
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 15:13:00 -0400
Received: from [199.232.76.173] (port=38946 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KuXWM-0004Kz-PS
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 15:12:58 -0400
Received: from mail-gx0-f17.google.com ([209.85.217.17]:40305)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KuXWL-0006Wy-E3
	for qemu-devel@nongnu.org; Mon, 27 Oct 2008 15:12:58 -0400
Received: by gxk10 with SMTP id 10so2929774gxk.10
	for <qemu-devel@nongnu.org>; Mon, 27 Oct 2008 12:12:54 -0700 (PDT)
Message-ID: <f43fc5580810271212p71ee1461v1e78d282beead85b@mail.gmail.com>
Date: Mon, 27 Oct 2008 21:12:53 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] sh4: mmio based CF support on r2d board.
In-Reply-To: <200810271857.m9RIvW14029178@smtp12.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080923013136.490117fd.yoshii.takashi@gmail.com>
	<200810261517.m9QFHUR4026096@smtp12.dti.ne.jp>
	<f43fc5580810260854q41264525xdaf9199686d9dcb8@mail.gmail.com>
	<200810271857.m9RIvW14029178@smtp12.dti.ne.jp>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "takasi-y@ops.dti.ne.jp" <takasi-y@ops.dti.ne.jp>
Cc: qemu-devel@nongnu.org

On 10/27/08, takasi-y@ops.dti.ne.jp <takasi-y@ops.dti.ne.jp> wrote:
>  > This should be in a .h file (maybe pc.h), without "extern" and the
>  > parameter names should be included.
>
> Sure. But, I wonder which file is suitable.
>  The system I accustomed to is like
>  - ide.c define function
>  - ide.h declare prototype
>  - pc.c include ide.h and refer the function.
>  But in QEMU, it looks like
>  - ide.c define function
>  - pc.h declare prototype
>  - pc.c include pc.h and refer the function.

I agree that the current .h system is not clear, I would prefer the
system you described. The reason is that otherwise there would be a
lot of files, many with just one function for device init.

>  Is it mean the prototype declaration should go into new file "r2d.h" ?

How about sh.h? It's already included from r2d.c.