From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KvHba-00059F-EN
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 16:25:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KvHbZ-000591-WD
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 16:25:26 -0400
Received: from [199.232.76.173] (port=38630 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KvHbZ-00058t-KY
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 16:25:25 -0400
Received: from yw-out-1718.google.com ([74.125.46.158]:60207)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KvHbZ-0003me-H3
	for qemu-devel@nongnu.org; Wed, 29 Oct 2008 16:25:25 -0400
Received: by yw-out-1718.google.com with SMTP id 6so66654ywa.82
	for <qemu-devel@nongnu.org>; Wed, 29 Oct 2008 13:25:24 -0700 (PDT)
Message-ID: <f43fc5580810291325n5c358e44k1274e1c8ee63553d@mail.gmail.com>
Date: Wed, 29 Oct 2008 22:25:23 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging
In-Reply-To: <200810292014.46351.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f43fc5580810291231i32552e3dw71db583d5b2bad6f@mail.gmail.com>
	<200810291953.09085.paul@codesourcery.com>
	<f43fc5580810291306r68cb4e95ke94ff8fa58ef3b02@mail.gmail.com>
	<200810292014.46351.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 10/29/08, Paul Brook <paul@codesourcery.com> wrote:
> On Wednesday 29 October 2008, Blue Swirl wrote:
>  > On 10/29/08, Paul Brook <paul@codesourcery.com> wrote:
>  > > On Wednesday 29 October 2008, Blue Swirl wrote:
>  > >  > Hi,
>  > >  >
>  > >  > When emulating a mixed 32/64 bit Qemu target CPUs it's easy to confuse
>  > >  > the TCGv size, passing 32 bit TCGv to a function expecting a 64 bit
>  > >  > one and vice versa. This patch adds a run time sanity check for TCGv
>  > >  > sizes.
>  > >
>  > > Would it make more sense to push these down into tcg_gen_op* ?
>  >
>  > How? At that point we don't know what was the correct size.
>
>
> I figure there's only a handful of different cases, so it'll be cleaner to
>  introduce tcg_gen_op_i32_i32 etc. which trivially reduce to tcg_gen_op2 when
>  debugging is disabled.

Now I see. I'll try that next.