* [Qemu-devel] Build breakage on OpenSolaris: --warn-common
@ 2008-10-31 21:08 Andreas Färber
2008-10-31 21:27 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2008-10-31 21:08 UTC (permalink / raw)
To: qemu-devel
Hello,
The following addition to configure at r5241 causes linking to fail on
OpenSolaris/amd64:
if ld --version 2>/dev/null | grep -q "GNU ld" ; then
LDFLAGS="$LDFLAGS -Wl,--warn-common"
fi
Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn-common
require an ld version newer than 2.15, or is this platform-dependent?
Previously I had also reported that Solaris 10's grep rejects -q. Could
we use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
Regards,
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
2008-10-31 21:08 [Qemu-devel] Build breakage on OpenSolaris: --warn-common Andreas Färber
@ 2008-10-31 21:27 ` Blue Swirl
2008-11-01 13:28 ` Andreas Färber
0 siblings, 1 reply; 6+ messages in thread
From: Blue Swirl @ 2008-10-31 21:27 UTC (permalink / raw)
To: qemu-devel
On 10/31/08, Andreas Färber <andreas.faerber@web.de> wrote:
> Hello,
>
> The following addition to configure at r5241 causes linking to fail on
> OpenSolaris/amd64:
>
> if ld --version 2>/dev/null | grep -q "GNU ld" ; then
> LDFLAGS="$LDFLAGS -Wl,--warn-common"
> fi
>
> Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn-common
> require an ld version newer than 2.15, or is this platform-dependent?
According to binutils changelog, --warn-common was added in 1993, so
maybe the platform breaks that. What does your ld print with ld
--version?
> Previously I had also reported that Solaris 10's grep rejects -q. Could we
> use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
Sure.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
2008-10-31 21:27 ` Blue Swirl
@ 2008-11-01 13:28 ` Andreas Färber
2008-11-01 14:03 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2008-11-01 13:28 UTC (permalink / raw)
To: qemu-devel
Am 31.10.2008 um 22:27 schrieb Blue Swirl:
> On 10/31/08, Andreas Färber <andreas.faerber@web.de> wrote:
>> The following addition to configure at r5241 causes linking to fail
>> on
>> OpenSolaris/amd64:
>>
>> if ld --version 2>/dev/null | grep -q "GNU ld" ; then
>> LDFLAGS="$LDFLAGS -Wl,--warn-common"
>> fi
>>
>> Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn-
>> common
>> require an ld version newer than 2.15, or is this platform-dependent?
>
> According to binutils changelog, --warn-common was added in 1993, so
> maybe the platform breaks that. What does your ld print with ld
> --version?
GNU ld version 2.15
Copyright 2002 Free Software Foundation, Inc.
This program is free software; [...]
So definitely past 1993. Any thoughts what to check for?
>
>> Previously I had also reported that Solaris 10's grep rejects -q.
>> Could we
>> use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
>
> Sure.
I'll prepare a patch for that part then.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
2008-11-01 13:28 ` Andreas Färber
@ 2008-11-01 14:03 ` Blue Swirl
2008-11-01 14:43 ` Andreas Färber
0 siblings, 1 reply; 6+ messages in thread
From: Blue Swirl @ 2008-11-01 14:03 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On 11/1/08, Andreas Färber <andreas.faerber@web.de> wrote:
>
> Am 31.10.2008 um 22:27 schrieb Blue Swirl:
>
>
> > On 10/31/08, Andreas Färber <andreas.faerber@web.de> wrote:
> >
> > > The following addition to configure at r5241 causes linking to fail on
> > > OpenSolaris/amd64:
> > >
> > > if ld --version 2>/dev/null | grep -q "GNU ld" ; then
> > > LDFLAGS="$LDFLAGS -Wl,--warn-common"
> > > fi
> > >
> > > Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn-common
> > > require an ld version newer than 2.15, or is this platform-dependent?
> > >
> >
> > According to binutils changelog, --warn-common was added in 1993, so
> > maybe the platform breaks that. What does your ld print with ld
> > --version?
> >
>
> GNU ld version 2.15
> Copyright 2002 Free Software Foundation, Inc.
> This program is free software; [...]
>
> So definitely past 1993. Any thoughts what to check for?
>
>
> >
> >
> > > Previously I had also reported that Solaris 10's grep rejects -q. Could
> we
> > > use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
> > >
> >
> > Sure.
> >
>
> I'll prepare a patch for that part then.
Does this one work?
[-- Attachment #2: fix_solaris_warn_common.diff --]
[-- Type: plain/text, Size: 639 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
2008-11-01 14:03 ` Blue Swirl
@ 2008-11-01 14:43 ` Andreas Färber
2008-11-01 14:51 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Färber @ 2008-11-01 14:43 UTC (permalink / raw)
To: qemu-devel
Am 01.11.2008 um 15:03 schrieb Blue Swirl:
> On 11/1/08, Andreas Färber <andreas.faerber@web.de> wrote:
>>
>> Am 31.10.2008 um 22:27 schrieb Blue Swirl:
>>
>>
>>> On 10/31/08, Andreas Färber <andreas.faerber@web.de> wrote:
>>>
>>>> The following addition to configure at r5241 causes linking to
>>>> fail on
>>>> OpenSolaris/amd64:
>>>>
>>>> if ld --version 2>/dev/null | grep -q "GNU ld" ; then
>>>> LDFLAGS="$LDFLAGS -Wl,--warn-common"
>>>> fi
>>>>
>>>> Contrary to Solaris 10, OpenSolaris does use GNU ld. Might --warn-
>>>> common
>>>> require an ld version newer than 2.15, or is this platform-
>>>> dependent?
>>>>
>>>
>>> According to binutils changelog, --warn-common was added in 1993, so
>>> maybe the platform breaks that. What does your ld print with ld
>>> --version?
>>>
>>
>> GNU ld version 2.15
>> Copyright 2002 Free Software Foundation, Inc.
>> This program is free software; [...]
>>
>> So definitely past 1993. Any thoughts what to check for?
>>
>>
>>>
>>>
>>>> Previously I had also reported that Solaris 10's grep rejects -q.
>>>> Could
>> we
>>>> use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
>>>>
>>>
>>> Sure.
>>>
>>
>> I'll prepare a patch for that part then.
>
> Does this one work?
> <fix_solaris_warn_common.diff>
It does on OpenSolaris, thanks. Easier than I thought. Please commit.
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] Build breakage on OpenSolaris: --warn-common
2008-11-01 14:43 ` Andreas Färber
@ 2008-11-01 14:51 ` Blue Swirl
0 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2008-11-01 14:51 UTC (permalink / raw)
To: qemu-devel
On 11/1/08, Andreas Färber <andreas.faerber@web.de> wrote:
>
> Am 01.11.2008 um 15:03 schrieb Blue Swirl:
>
>
> >
> > On 11/1/08, Andreas Färber <andreas.faerber@web.de> wrote:
> >
> > >
> > > Am 31.10.2008 um 22:27 schrieb Blue Swirl:
> > >
> > >
> > >
> > > > On 10/31/08, Andreas Färber <andreas.faerber@web.de> wrote:
> > > >
> > > >
> > > > > The following addition to configure at r5241 causes linking to fail
> on
> > > > > OpenSolaris/amd64:
> > > > >
> > > > > if ld --version 2>/dev/null | grep -q "GNU ld" ; then
> > > > > LDFLAGS="$LDFLAGS -Wl,--warn-common"
> > > > > fi
> > > > >
> > > > > Contrary to Solaris 10, OpenSolaris does use GNU ld. Might
> --warn-common
> > > > > require an ld version newer than 2.15, or is this
> platform-dependent?
> > > > >
> > > > >
> > > >
> > > > According to binutils changelog, --warn-common was added in 1993, so
> > > > maybe the platform breaks that. What does your ld print with ld
> > > > --version?
> > > >
> > > >
> > >
> > > GNU ld version 2.15
> > > Copyright 2002 Free Software Foundation, Inc.
> > > This program is free software; [...]
> > >
> > > So definitely past 1993. Any thoughts what to check for?
> > >
> > >
> > >
> > > >
> > > >
> > > >
> > > > > Previously I had also reported that Solaris 10's grep rejects -q.
> Could
> > > > >
> > > >
> > > we
> > >
> > > >
> > > > > use `grep "GNU ld" >/dev/null 2>/dev/null` instead?
> > > > >
> > > > >
> > > >
> > > > Sure.
> > > >
> > > >
> > >
> > > I'll prepare a patch for that part then.
> > >
> >
> > Does this one work?
> > <fix_solaris_warn_common.diff>
> >
>
> It does on OpenSolaris, thanks. Easier than I thought. Please commit.
Committed as r5594, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-11-01 14:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-31 21:08 [Qemu-devel] Build breakage on OpenSolaris: --warn-common Andreas Färber
2008-10-31 21:27 ` Blue Swirl
2008-11-01 13:28 ` Andreas Färber
2008-11-01 14:03 ` Blue Swirl
2008-11-01 14:43 ` Andreas Färber
2008-11-01 14:51 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).