From: "Blue Swirl" <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging
Date: Sat, 1 Nov 2008 19:03:11 +0200 [thread overview]
Message-ID: <f43fc5580811011003j4d70d0fal4390fd164cf5406e@mail.gmail.com> (raw)
In-Reply-To: <200811011656.29847.paul@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On 11/1/08, Paul Brook <paul@codesourcery.com> wrote:
> > > With the patch, I found some bugs in Sparc translation. I'm not sure
> > > what to do with helpers, there should be a way to declare the size of
> > > the arguments somehow and then the calling should be easier than:
> > > tcg_gen_helper_1_4_i64_tl_i32_i32_i32(helper_ld_asi, dst, addr, r_asi,
> > > r_size, r_sign);
> >
> > I think we can build some infrastructure to make helpers easier to handle.
> > It should be relatively mechanical changes to the existing helper[s].h.
> > ARM and m68k already do this, though need a bit more work to get static
> > typechecking. All the information it there's it's just not quite in the
> > right form. I'll see if I can dig out the CPP magic required for this.
>
>
> I've got something that works. Any chance you could resend you patch with a
> signed-off-by line so I can do the integration?
I don't trust these much, but anyway:
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
[-- Attachment #2: compile_time_tcgv_size_check.diff.bz2 --]
[-- Type: application/x-bzip2, Size: 14840 bytes --]
prev parent reply other threads:[~2008-11-01 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 19:31 [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging Blue Swirl
2008-10-29 19:53 ` Paul Brook
2008-10-29 20:06 ` Blue Swirl
2008-10-29 20:14 ` Paul Brook
2008-10-29 20:25 ` Blue Swirl
2008-10-29 21:37 ` [Qemu-devel] " Fabrice Bellard
2008-10-30 0:07 ` Paul Brook
2008-10-30 9:38 ` Fabrice Bellard
2008-11-01 12:00 ` Blue Swirl
2008-11-01 12:59 ` Paul Brook
2008-11-01 16:56 ` Paul Brook
2008-11-01 17:03 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580811011003j4d70d0fal4390fd164cf5406e@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).