qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Patch for qemu-0.9.1/slirp/misc.c:getouraddr
Date: Sun, 9 Nov 2008 13:43:07 +0200	[thread overview]
Message-ID: <f43fc5580811090343j31313f2bue8c1dc8a1d3c5d93@mail.gmail.com> (raw)
In-Reply-To: <e8c553a60811071042radc9459r3b53564795473bda@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On 11/7/08, Wan-Teh Chang <wtc@google.com> wrote:
> Attached is a patch for qemu-0.9.1/slirp/misc.c to implement
>  the getouraddr() function using the BSD function getifaddrs(),
>  which is also available in glibc on Linux.

How is this better than the current way? Does this change something on
hosts with multiple interfaces? What if some interfaces are down?

>  This patch does not include the necessary change to define
>  HAVE_GETIFADDRS on the platforms that have getifaddrs().
>  You will need to either use an autoconf test for getifaddrs(),

I added probing for getifaddrs to configure in the attached patch,
seems to work.

[-- Attachment #2: getifaddrs_wtc.diff --]
[-- Type: plain/text, Size: 1866 bytes --]

  reply	other threads:[~2008-11-09 11:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07 18:42 [Qemu-devel] Patch for qemu-0.9.1/slirp/misc.c:getouraddr Wan-Teh Chang
2008-11-09 11:43 ` Blue Swirl [this message]
2008-11-10 18:04   ` Wan-Teh Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580811090343j31313f2bue8c1dc8a1d3c5d93@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).