From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kz8hC-00039x-Tv for qemu-devel@nongnu.org; Sun, 09 Nov 2008 06:43:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kz8hB-00039l-Ez for qemu-devel@nongnu.org; Sun, 09 Nov 2008 06:43:10 -0500 Received: from [199.232.76.173] (port=53856 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kz8hB-00039i-96 for qemu-devel@nongnu.org; Sun, 09 Nov 2008 06:43:09 -0500 Received: from wf-out-1314.google.com ([209.85.200.172]:52477) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kz8hA-0000ag-QR for qemu-devel@nongnu.org; Sun, 09 Nov 2008 06:43:09 -0500 Received: by wf-out-1314.google.com with SMTP id 27so2064699wfd.4 for ; Sun, 09 Nov 2008 03:43:07 -0800 (PST) Message-ID: Date: Sun, 9 Nov 2008 13:43:07 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] Patch for qemu-0.9.1/slirp/misc.c:getouraddr In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_85677_6666904.1226230987507" References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_85677_6666904.1226230987507 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 11/7/08, Wan-Teh Chang wrote: > Attached is a patch for qemu-0.9.1/slirp/misc.c to implement > the getouraddr() function using the BSD function getifaddrs(), > which is also available in glibc on Linux. How is this better than the current way? Does this change something on hosts with multiple interfaces? What if some interfaces are down? > This patch does not include the necessary change to define > HAVE_GETIFADDRS on the platforms that have getifaddrs(). > You will need to either use an autoconf test for getifaddrs(), I added probing for getifaddrs to configure in the attached patch, seems to work. ------=_Part_85677_6666904.1226230987507 Content-Type: plain/text; name=getifaddrs_wtc.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fnbm65ec Content-Disposition: attachment; filename=getifaddrs_wtc.diff SW5kZXg6IHFlbXUvc2xpcnAvbWlzYy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9zbGlycC9t aXNjLmMJMjAwOC0xMS0wOSAwOTozMDoxMS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvc2xpcnAv bWlzYy5jCTIwMDgtMTEtMDkgMDk6NDA6NDQuMDAwMDAwMDAwICswMDAwCkBAIC03LDYgKzcsOSBA QAogCiAjZGVmaW5lIFdBTlRfU1lTX0lPQ1RMX0gKICNpbmNsdWRlIDxzbGlycC5oPgorI2lmZGVm IEhBVkVfR0VUSUZBRERSUworI2luY2x1ZGUgPGlmYWRkcnMuaD4KKyNlbmRpZgogCiB1X2ludCBj dXJ0aW1lLCB0aW1lX2Zhc3R0aW1vLCBsYXN0X3Nsb3d0aW1vOwogCkBAIC03Miw2ICs3NSwyNiBA QAogdm9pZAogZ2V0b3VyYWRkcigpCiB7CisjaWZkZWYgSEFWRV9HRVRJRkFERFJTCisJc3RydWN0 IGlmYWRkcnMgKmlmcDsKKworCWlmIChnZXRpZmFkZHJzKCZpZnApID09IDApIHsKKwkgICAgc3Ry dWN0IGlmYWRkcnMgKmlmYTsKKwkgICAgZm9yIChpZmEgPSBpZnA7IGlmYTsgaWZhID0gaWZhLT5p ZmFfbmV4dCkgeworCSAgICAgICAgc3RydWN0IHNvY2thZGRyICpzYTsKKworCSAgICAgICAgc2Eg PSBpZmEtPmlmYV9hZGRyOworCSAgICAgICAgaWYgKHNhLT5zYV9mYW1pbHkgPT0gQUZfSU5FVCkg eworCSAgICAgICAgICAgIHN0cnVjdCBzb2NrYWRkcl9pbiAqc2luID0gKHN0cnVjdCBzb2NrYWRk cl9pbiAqKSBzYTsKKwkgICAgICAgICAgICBpZiAoc2luLT5zaW5fYWRkci5zX2FkZHIgIT0gaHRv bmwoSU5BRERSX0xPT1BCQUNLKSkgeworCSAgICAgICAgICAgICAgICBvdXJfYWRkciA9IHNpbi0+ c2luX2FkZHI7CisJICAgICAgICAgICAgICAgIGJyZWFrOworCSAgICAgICAgICAgIH0KKwkgICAg ICAgIH0KKwkgICAgfQorCSAgICBmcmVlaWZhZGRycyhpZnApOworCX0KKyNlbHNlCiAJY2hhciBi dWZmWzI1Nl07CiAJc3RydWN0IGhvc3RlbnQgKmhlID0gTlVMTDsKIApAQCAtNzksNiArMTAyLDcg QEAKICAgICAgICAgICAgIGhlID0gZ2V0aG9zdGJ5bmFtZShidWZmKTsKICAgICAgICAgaWYgKGhl KQogICAgICAgICAgICAgb3VyX2FkZHIgPSAqKHN0cnVjdCBpbl9hZGRyICopaGUtPmhfYWRkcjsK KyNlbmRpZgogICAgICAgICBpZiAob3VyX2FkZHIuc19hZGRyID09IDApCiAgICAgICAgICAgICBv dXJfYWRkci5zX2FkZHIgPSBsb29wYmFja19hZGRyLnNfYWRkcjsKIH0KSW5kZXg6IHFlbXUvY29u ZmlndXJlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9jb25maWd1cmUJMjAwOC0xMS0wOSAwOToz MDoxMS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvY29uZmlndXJlCTIwMDgtMTEtMDkgMDk6MzE6 NDQuMDAwMDAwMDAwICswMDAwCkBAIC0xMjEyLDYgKzEyMTIsMTcgQEAKICAgZmkKIGZpCiAKKyMg Q2hlY2sgZm9yIGdldGlmYWRkcnMgc3VwcG9ydAorY2F0ID4gJFRNUEMgPDwgRU9GCisjaW5jbHVk ZSA8c3lzL3R5cGVzLmg+CisjaW5jbHVkZSA8c3lzL3NvY2tldC5oPgorI2luY2x1ZGUgPGlmYWRk cnMuaD4KK2ludCBtYWluKHZvaWQpIHsgc3RydWN0IGlmYWRkcnMgKmlmcDsgcmV0dXJuIGdldGlm YWRkcnMoJmlmcCk7IH0KK0VPRgoraWYgJGNjICRBUkNIX0NGTEFHUyAtbyAkVE1QRSAkVE1QQyAy PiAvZGV2L251bGwgOyB0aGVuCisgIGVjaG8gIiNkZWZpbmUgSEFWRV9HRVRJRkFERFJTIDEiID4+ ICRjb25maWdfaAorZmkKKwogaWYgWyAiJG9wZW5ic2QiID0gInllcyIgXSA7IHRoZW4KICAgZWNo byAiI2RlZmluZSBFTk9UU1VQIDQwOTYiID4+ICRjb25maWdfaAogZmkK ------=_Part_85677_6666904.1226230987507--