Re: [Qemu-devel] [PATCH] DM9000 network card driver

["Blue Swirl" <blauwirbel@gmail.com>]

On 11/10/08, Daniel Silverstone <dsilvers@simtec.co.uk> wrote:
> On Mon, 2008-10-27 at 10:49 +0000, Daniel Silverstone wrote:
>  > I think this fell through the cracks, so here it is again.
>  > The Davicom DM9000 10/100 Ethernet controller.
>
>  I don't see any replies to this -- it's possible that my list
>  subscription was playing up at the time, so I thought I'd re-poke about
>  it.
>
>  Basically I'm desperate to know if I'm even going the right way in my
>  patches -- am I getting them to a state where they could be merged, or
>  am I wasting my time? Is there an FAQ I need to read which will tell me
>  how to present these patches in a way which is easier for you all to
>  deal with them?
>
>  I'm just somewhat disheartened that I see patches turn up and get
>  discussed strongly, and then the updated patches end up being merged,
>  where after the initial discussion, this patch kinda got dropped on the
>  floor without an explicit "no" or anything; sitting for two weeks
>  untouched on-list.
>
>  I appreciate that you're all busy, so if the answer is simply "You're on
>  the list, just it'll be a while" then at least I can carry that back to
>  my boss who wants to know how it's going getting these patches to you.

Well, for example I could comment on the patches from general point of
view (as I seem to have more time in my hands than some), but then I
don't usually have any means to check if the emulator (or the device)
in question even works with patch applied, or whether the patch makes
sense from the machine architecture POV. For that, the maintainer
should OK the patch.

Your patch looks very clean. I wouldn't use devices.h for the
prototype, but instead some board file (for example arm-misc.h).

The device is not used by any board, so it's not possible even for the
maintainer to test the patch.

As there is a reset function already, it should not be too difficult
to register that for system_reset use.

Save/load functions would be nice, though IIRC ARM boards/devices
don't have any yet.