From: "Blue Swirl" <blauwirbel@gmail.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] fix warnings on NetBSD
Date: Mon, 10 Nov 2008 18:56:58 +0200 [thread overview]
Message-ID: <f43fc5580811100856i76b29e83h1bdef2244170faa2@mail.gmail.com> (raw)
In-Reply-To: <200811101735.34880.Christoph.Egger@amd.com>
On 11/10/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
> On Monday 10 November 2008 17:03:27 Blue Swirl wrote:
> > On 11/10/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
> > > Hi!
> > >
> > > Attached patch fixes a series of this warning
> > > when compiling on NetBSD:
> > >
> > > warning: array subscript has type 'char'
> >
> > There has been some discussion on ctype.h macro problems, please see:
> > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01239.html
> >
> > I'd vote for introducing qemu_isfoobar and qemu_towombat instead of casts.
>
>
> Attached patch introduces a CTYPE macro as mentioned on this mail.
> The diff in qemu-common.h has been taken from xen ioemu.
Sorry, you must have missed the two follow-up messages:
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01252.html
http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01292.html
So instead of CTYPE macro, there should be qemu_toupper, qemu_isalpha
etc. which handle char arguments correctly even when sign extension
happens.
next prev parent reply other threads:[~2008-11-10 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 9:55 [Qemu-devel] [PATCH] fix warnings on NetBSD Christoph Egger
2008-11-10 16:03 ` [Qemu-devel] " Blue Swirl
2008-11-10 16:35 ` Christoph Egger
2008-11-10 16:56 ` Blue Swirl [this message]
2008-11-11 9:46 ` Christoph Egger
2008-11-11 17:45 ` Blue Swirl
2008-11-11 17:53 ` Anthony Liguori
2008-11-16 14:04 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580811100856i76b29e83h1bdef2244170faa2@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=Christoph.Egger@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).