From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KzxJJ-0008CS-CJ
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 12:45:53 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KzxJI-0008BP-Ho
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 12:45:53 -0500
Received: from [199.232.76.173] (port=36073 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KzxJI-0008BE-Cl
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 12:45:52 -0500
Received: from yw-out-1718.google.com ([74.125.46.157]:27541)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KzxJH-00087N-Ly
	for qemu-devel@nongnu.org; Tue, 11 Nov 2008 12:45:52 -0500
Received: by yw-out-1718.google.com with SMTP id 6so1107447ywa.82
	for <qemu-devel@nongnu.org>; Tue, 11 Nov 2008 09:45:50 -0800 (PST)
Message-ID: <f43fc5580811110945s4f44220m23c37e18e7bb1060@mail.gmail.com>
Date: Tue, 11 Nov 2008 19:45:49 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
In-Reply-To: <200811111046.20149.Christoph.Egger@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200811101055.17281.Christoph.Egger@amd.com>
	<200811101735.34880.Christoph.Egger@amd.com>
	<f43fc5580811100856i76b29e83h1bdef2244170faa2@mail.gmail.com>
	<200811111046.20149.Christoph.Egger@amd.com>
Subject: [Qemu-devel] Re: [PATCH] fix warnings on NetBSD
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Egger <Christoph.Egger@amd.com>, Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On 11/11/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
> On Monday 10 November 2008 17:56:58 Blue Swirl wrote:
>  > On 11/10/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
>  > > On Monday 10 November 2008 17:03:27 Blue Swirl wrote:
>  > >  > On 11/10/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
>  > >  > >  Hi!
>  > >  > >
>  > >  > >  Attached patch fixes a series of this warning
>  > >  > >  when compiling on NetBSD:
>  > >  > >
>  > >  > >  warning: array subscript has type 'char'
>  > >  >
>  > >  > There has been some discussion on ctype.h macro problems, please see:
>  > >  > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01239.html
>  > >  >
>  > >  > I'd vote for introducing qemu_isfoobar and qemu_towombat instead of
>  > >  > casts.
>  > >
>  > > Attached patch introduces a CTYPE macro as mentioned on this mail.
>  > >  The diff in qemu-common.h has been taken from xen ioemu.
>  >
>  > Sorry, you must have missed the two follow-up messages:
>  > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01252.html
>  > http://lists.gnu.org/archive/html/qemu-devel/2008-08/msg01292.html
>  >
>  > So instead of CTYPE macro, there should be qemu_toupper, qemu_isalpha
>  > etc. which handle char arguments correctly even when sign extension
>  > happens.
>
>
> New patch attached. Better now ?
>
>
>  Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Looks good to me. Anybody mind if I commit it? Anthony, happy with this version?