From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2AOg-0001mI-6q
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:08:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2AOe-0001lW-Rx
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:08:33 -0500
Received: from [199.232.76.173] (port=42919 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2AOe-0001lR-Mt
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:08:32 -0500
Received: from nf-out-0910.google.com ([64.233.182.191]:14705)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1L2AOe-0002zd-CG
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 15:08:32 -0500
Received: by nf-out-0910.google.com with SMTP id b2so1998561nfb.12
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 12:08:31 -0800 (PST)
Message-ID: <f43fc5580811171208y118caa86qf71629a6f033867f@mail.gmail.com>
Date: Mon, 17 Nov 2008 22:08:31 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] TCG debugging improvements
In-Reply-To: <200811171445.40710.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200811171445.40710.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/17/08, Paul Brook <paul@codesourcery.com> wrote:
> I'd just applied changes that enforce type size checking for TCG variables
>  when DEBUG_TCGV is defined. This should help avoid subtle bugs due to
>  64/32-bit mismatches.
>
>  I fixed a few bugs in the process, but it's mostly mechanical changes.  TCGv
>  is target_ulong sized, so the majority of code remains unchanged.  Explicit
>  sizes are typically only required when working with different sized ops, or
>  floating point.
>
>  One of the main side-effects of this is that helper functions now need to be
>  declared properly.  Previously we sort-of did this, but not consistently
>  enough to enforce types.  With the exception of the SSE/MMX ops (which are
>  table driven and use messy typecasts) we should be able to detect
>  inconsistencies between the code generator and the helper function
>  implementations.
>
>  There should be no functional changes.  I've tested what I can, but please
>  test your favourite host/target.

PPC is broken. This used to print something, now it doesn't:
./qemu-system-ppc -L ./pc-bios/ -hda /dev/null

Sparc32 and Sparc64 are fine, thanks for the fixes.