qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] handle MAP_FLAGMASK
Date: Wed, 26 Nov 2008 19:21:11 +0200	[thread overview]
Message-ID: <f43fc5580811260921k275880f9h4dcfff43fcfc0ed4@mail.gmail.com> (raw)
In-Reply-To: <200811261127.23684.Christoph.Egger@amd.com>

On 11/26/08, Christoph Egger <Christoph.Egger@amd.com> wrote:
>
>  Hi,
>
>  NetBSD doesn't have MAP_FLAGMASK. Attached patch fixes this.

The code blindly uses native definitions, but the BSDs differ in some cases.

FreeBSD:
#define	MAP_HASSEMAPHORE 0x0200	/* region may contain semaphores */
#define	MAP_STACK	 0x0400	/* region grows down, like a stack */
#define	MAP_NOSYNC	 0x0800 /* page to but do not sync underlying file */

NetBSD:
#define	MAP_HASSEMAPHORE 0x0200	/* region may contain semaphores */
#define	MAP_TRYFIXED     0x0400 /* attempt hint address, even within break */
#define	MAP_WIRED	 0x0800	/* mlock() mapping when it is established */

OpenBSD:
#define	MAP_HASSEMAPHORE 0x0200	/* region may contain semaphores */
#define	MAP_TRYFIXED	 0x0400 /* attempt hint address, even within heap */

Same for madvise flags.

So we need TARGET_FREEBSD_MAP_HASSEMAPHORE etc. and specific handling
for each OS, like the syscalls are handled.

      reply	other threads:[~2008-11-26 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 10:27 [Qemu-devel] [PATCH] handle MAP_FLAGMASK Christoph Egger
2008-11-26 17:21 ` Blue Swirl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580811260921k275880f9h4dcfff43fcfc0ed4@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=Christoph.Egger@amd.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).