[Qemu-devel] [PATCH] ESP: misc fixes

[Qemu-devel] [PATCH] ESP: misc fixes

[Hervé Poussineau]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

Hi,

Attached patches fix a few problems with ESP scsi card emulation.


Misc fixes (esp_1_misc.diff)
- Fix internal fifo size (16 bytes), according to 
http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
- Fix values of STAT_MI and STAT_MO
- Give a scsi ID to adapter, and prevent this ID to be used by devices
- Prevent fifo overrun in esp_mem_writeb
- Add a ESP_ERROR macro, and use it where appropriate


Fix configuration 2 register (esp_2_cfg2.diff):
According to 
http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt 
, "Any bit pattern written to this register
may be read back and should be identical"


Fix command len detection (esp_3_cmdlen.diff)
When command is not DMA, TCMID and TCLO registers are not filled. Use 
command buffer len instead


Fix 'enable selection' command (esp_4_ensel.diff)
Indicate success after 'enable selection' command


Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>


These patches have been tested on Sparc SS-5 and on Mips Magnum emulations.

Hervé

[-- Attachment #2: esp_4_ensel.diff --]
[-- Type: plain/text, Size: 403 bytes --]

[-- Attachment #3: esp_1_misc.diff --]
[-- Type: plain/text, Size: 3531 bytes --]

[-- Attachment #4: esp_2_cfg2.diff --]
[-- Type: plain/text, Size: 581 bytes --]

[-- Attachment #5: esp_3_cmdlen.diff --]
[-- Type: plain/text, Size: 801 bytes --]

Re: [Qemu-devel] [PATCH] ESP: misc fixes

[Blue Swirl]

On 11/29/08, Hervé Poussineau <hpoussin@reactos.org> wrote:
> Hi,
>
>  Attached patches fix a few problems with ESP scsi card emulation.
>
>
>  Misc fixes (esp_1_misc.diff)
>  - Fix internal fifo size (16 bytes), according to
> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
>  - Fix values of STAT_MI and STAT_MO
>  - Give a scsi ID to adapter, and prevent this ID to be used by devices
>  - Prevent fifo overrun in esp_mem_writeb
>  - Add a ESP_ERROR macro, and use it where appropriate
>
>
>  Fix configuration 2 register (esp_2_cfg2.diff):
>  According to
> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
> , "Any bit pattern written to this register
>  may be read back and should be identical"
>
>
>  Fix command len detection (esp_3_cmdlen.diff)
>  When command is not DMA, TCMID and TCLO registers are not filled. Use
> command buffer len instead
>
>
>  Fix 'enable selection' command (esp_4_ensel.diff)
>  Indicate success after 'enable selection' command
>
>
>  Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>
>
>  These patches have been tested on Sparc SS-5 and on Mips Magnum emulations.

Thanks, applied as r5811, r5812, r5813 and r5814.

Re: [Qemu-devel] [PATCH] ESP: misc fixes

[Blue Swirl]

On 11/29/08, Hervé Poussineau <hpoussin@reactos.org> wrote:
> Hi,
>
>  Attached patches fix a few problems with ESP scsi card emulation.
>
>
>  Misc fixes (esp_1_misc.diff)
>  - Fix internal fifo size (16 bytes), according to
> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
>  - Fix values of STAT_MI and STAT_MO
>  - Give a scsi ID to adapter, and prevent this ID to be used by devices
>  - Prevent fifo overrun in esp_mem_writeb
>  - Add a ESP_ERROR macro, and use it where appropriate
>
>
>  Fix configuration 2 register (esp_2_cfg2.diff):
>  According to
> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
> , "Any bit pattern written to this register
>  may be read back and should be identical"
>
>
>  Fix command len detection (esp_3_cmdlen.diff)
>  When command is not DMA, TCMID and TCLO registers are not filled. Use
> command buffer len instead
>
>
>  Fix 'enable selection' command (esp_4_ensel.diff)
>  Indicate success after 'enable selection' command
>
>
>  Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>
>
>  These patches have been tested on Sparc SS-5 and on Mips Magnum emulations.

With these patches, MirBSD reaches userland (though then it gets a
NMI), previously there were some messages about PIO support. Great!