From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L6rAD-0003Jz-C2
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:37:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L6rAB-0003GF-Lq
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:37:00 -0500
Received: from [199.232.76.173] (port=52611 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L6rAB-0003Fu-HZ
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:36:59 -0500
Received: from mu-out-0910.google.com ([209.85.134.189]:23878)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1L6rAB-0000EH-13
	for qemu-devel@nongnu.org; Sun, 30 Nov 2008 13:36:59 -0500
Received: by mu-out-0910.google.com with SMTP id w1so1977654mue.2
	for <qemu-devel@nongnu.org>; Sun, 30 Nov 2008 10:36:56 -0800 (PST)
Message-ID: <f43fc5580811301036r19c15898me62cc07b16da71ba@mail.gmail.com>
Date: Sun, 30 Nov 2008 20:36:56 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
In-Reply-To: <20081130174133.GC32172@random.random>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081127123538.GC10348@random.random>
	<f43fc5580811271114u7ecc3277kc7518fb7dbf9b4c0@mail.gmail.com>
	<20081128015602.GA31011@random.random>
	<f43fc5580811280959k3410e62eq7a2a46417b438b64@mail.gmail.com>
	<20081128185001.GD31011@random.random>
	<20081130174133.GC32172@random.random>
Subject: [Qemu-devel] Re: [RFC 1/1] pci-dma-api-v2
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/30/08, Andrea Arcangeli <aarcange@redhat.com> wrote:
> On Fri, Nov 28, 2008 at 07:50:01PM +0100, Andrea Arcangeli wrote:
>  > better. I've also noticed some problems with windows (I didn't test
>  > windows before posting), those aren't related to the cache layer as I
>  > added a #define to disable it and replace it with malloc/free. But
>  > that's not the cache layer, as soon as windows runs completely
>  > flawlessy I post an update.
>
>  As promised here an updated. I fixed all outstanding issues, it's
>  running rock solid. Before there were a few spots on ide.c plus the
>  cache layer was very buggy with more than one dma in-flight.

The patch does not apply as is:
>  --- hw/ide.c    (revision 5818)
>  +++ hw/ide.c    (working copy)
>  diff --git a/qemu/hw/pci_dma.c b/qemu/hw/pci_dma.c
>  new file mode 100644
>  index 0000000..48762a8
>  --- /dev/null
>  +++ b/qemu/hw/pci_dma.c
>  diff --git a/qemu/hw/pci_dma.h b/qemu/hw/pci_dma.h
>  new file mode 100644
>  index 0000000..5cc8413
>  --- /dev/null
>  +++ b/qemu/hw/pci_dma.h

Even as I fixed the patch, it still does not compile, for example:
/src/qemu/block.c:1335: warning: 'struct iovec' declared inside parameter list
/src/qemu/block.c:1336: error: conflicting types for 'bdrv_aio_writev'
/src/qemu/block.h:106: error: previous declaration of 'bdrv_aio_writev' was here
/src/qemu/block.c:1425: error: invalid use of undefined type 'struct iovec'