From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>
Subject: Re: [Qemu-devel] [PATCH] Allow to register a callback with fw_cfg_add_callback()
Date: Thu, 11 Dec 2008 19:33:58 +0200 [thread overview]
Message-ID: <f43fc5580812110933l3ef7b43q77bae0534bc7620f@mail.gmail.com> (raw)
In-Reply-To: <20081211153253.GO5555@redhat.com>
On 12/11/08, Gleb Natapov <gleb@redhat.com> wrote:
> On Thu, Dec 11, 2008 at 04:09:28PM +0100, Laurent Vivier wrote:
> > fw_cfg_add_callback() checks if key has FW_CFG_WRITE_CHANNEL bit set
> > after masking the key with FW_CFG_ENTRY_MASK.
> >
> > But as FW_CFG_ENTRY_MASK is ~(FW_CFG_WRITE_CHANNEL | FW_CFG_ARCH_LOCAL),
> > the bit is never set and function exits.
> >
> > This patch corrects this by checking the bit before masking the value.
> >
> > Signed-by-off: Laurent Vivier <Laurent.Vivier@bull.net>
>
> Acked-by: Gleb Natapov <gleb@redhat.com>
Thanks, committed in r5978.
prev parent reply other threads:[~2008-12-11 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 15:09 [Qemu-devel] [PATCH] Allow to register a callback with fw_cfg_add_callback() Laurent Vivier
2008-12-11 15:32 ` Gleb Natapov
2008-12-11 17:33 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580812110933l3ef7b43q77bae0534bc7620f@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=Laurent.Vivier@bull.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).