From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LApQH-0000BJ-Qi
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:34:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LApQH-0000As-9I
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:34:01 -0500
Received: from [199.232.76.173] (port=49728 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LApQH-0000Aj-3W
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:34:01 -0500
Received: from yw-out-1718.google.com ([74.125.46.156]:43654)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LApQG-0004VK-N4
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:34:00 -0500
Received: by yw-out-1718.google.com with SMTP id 6so478307ywa.82
	for <qemu-devel@nongnu.org>; Thu, 11 Dec 2008 09:33:59 -0800 (PST)
Message-ID: <f43fc5580812110933l3ef7b43q77bae0534bc7620f@mail.gmail.com>
Date: Thu, 11 Dec 2008 19:33:58 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Allow to register a callback with
	fw_cfg_add_callback()
In-Reply-To: <20081211153253.GO5555@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1229008168-8012-1-git-send-email-Laurent.Vivier@bull.net>
	<20081211153253.GO5555@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>

On 12/11/08, Gleb Natapov <gleb@redhat.com> wrote:
> On Thu, Dec 11, 2008 at 04:09:28PM +0100, Laurent Vivier wrote:
>  > fw_cfg_add_callback() checks if key has FW_CFG_WRITE_CHANNEL bit set
>  > after masking the key with FW_CFG_ENTRY_MASK.
>  >
>  > But as FW_CFG_ENTRY_MASK is ~(FW_CFG_WRITE_CHANNEL | FW_CFG_ARCH_LOCAL),
>  > the bit is never set and function exits.
>  >
>  > This patch corrects this by checking the bit before masking the value.
>  >
>  > Signed-by-off: Laurent Vivier <Laurent.Vivier@bull.net>
>
> Acked-by: Gleb Natapov <gleb@redhat.com>

Thanks, committed in r5978.