From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBR1y-00038u-1s
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:43:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBR1w-000366-3f
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:43:25 -0500
Received: from [199.232.76.173] (port=57208 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBR1w-00035u-0N
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:43:24 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:34594)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LBR1v-0001R1-GL
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:43:23 -0500
Received: by bwz5 with SMTP id 5so2850309bwz.10
	for <qemu-devel@nongnu.org>; Sat, 13 Dec 2008 01:43:21 -0800 (PST)
Message-ID: <f43fc5580812130143w68b2f8deoc135af466e5e53d2@mail.gmail.com>
Date: Sat, 13 Dec 2008 11:43:21 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG
In-Reply-To: <49437EF9.6000704@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1LBPg5-0003IJ-B9@cvs.savannah.gnu.org> <49437EF9.6000704@web.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/13/08, Jan Kiszka <jan.kiszka@web.de> wrote:
> Blue Swirl wrote:
>  > Revision: 5998
>  >           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5998
>  > Author:   blueswir1
>  > Date:     2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008)
>  >
>  > Log Message:
>  > -----------
>  > Fix TARGET_LONG_BITS warning in TCG
>  >
>  > Looking at tcg/tcg.c:828, the bug that the warning indicated would show up as
>  > incorrect PC shown in log, only on 32 bit big endian host emulating a 64 bit
>  > target, -d op flag enabled. Now that dyngen is gone, the patch can be applied.
>  >
>  > Modified Paths:
>  > --------------
>  >     trunk/tcg/tcg-runtime.c
>  >
>  > Modified: trunk/tcg/tcg-runtime.c
>  > ===================================================================
>  > --- trunk/tcg/tcg-runtime.c   2008-12-12 20:02:52 UTC (rev 5997)
>  > +++ trunk/tcg/tcg-runtime.c   2008-12-13 08:16:43 UTC (rev 5998)
>  > @@ -29,6 +29,7 @@
>  >
>  >  #include "config.h"
>  >  #include "osdep.h"
>  > +#include "cpu.h" // For TARGET_LONG_BITS
>  >  #include "tcg.h"
>  >
>  >  int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2)
>  >
>
>
> Nice that this warning is finally fixed - but what is the point of
>  including all those headers at all here? [1] worked well for me while
>  reducing dependencies.

I think all header files should be checked and even reorganized when
necessary. One item is the dyngen removal, cpu.h/exec.h distinction is
not clear for all targets and headers used by both user and system
emulators could be adjusted. Header files in hw should be OK, but
worth checking.