From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBRd2-0001wT-QB for qemu-devel@nongnu.org; Sat, 13 Dec 2008 05:21:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBRcz-0001uW-Ra for qemu-devel@nongnu.org; Sat, 13 Dec 2008 05:21:43 -0500 Received: from [199.232.76.173] (port=40730 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBRcz-0001uL-GW for qemu-devel@nongnu.org; Sat, 13 Dec 2008 05:21:41 -0500 Received: from mail-bw0-f12.google.com ([209.85.218.12]:49688) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBRcy-0005p1-FA for qemu-devel@nongnu.org; Sat, 13 Dec 2008 05:21:41 -0500 Received: by bwz5 with SMTP id 5so2869189bwz.10 for ; Sat, 13 Dec 2008 02:21:39 -0800 (PST) Message-ID: Date: Sat, 13 Dec 2008 12:21:28 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG In-Reply-To: <494386C7.80703@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <49437EF9.6000704@web.de> <494386C7.80703@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/13/08, Jan Kiszka wrote: > Blue Swirl wrote: > > On 12/13/08, Jan Kiszka wrote: > >> Blue Swirl wrote: > >> > Revision: 5998 > >> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5998 > >> > Author: blueswir1 > >> > Date: 2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008) > >> > > >> > Log Message: > >> > ----------- > >> > Fix TARGET_LONG_BITS warning in TCG > >> > > >> > Looking at tcg/tcg.c:828, the bug that the warning indicated would show up as > >> > incorrect PC shown in log, only on 32 bit big endian host emulating a 64 bit > >> > target, -d op flag enabled. Now that dyngen is gone, the patch can be applied. > >> > > >> > Modified Paths: > >> > -------------- > >> > trunk/tcg/tcg-runtime.c > >> > > >> > Modified: trunk/tcg/tcg-runtime.c > >> > =================================================================== > >> > --- trunk/tcg/tcg-runtime.c 2008-12-12 20:02:52 UTC (rev 5997) > >> > +++ trunk/tcg/tcg-runtime.c 2008-12-13 08:16:43 UTC (rev 5998) > >> > @@ -29,6 +29,7 @@ > >> > > >> > #include "config.h" > >> > #include "osdep.h" > >> > +#include "cpu.h" // For TARGET_LONG_BITS > >> > #include "tcg.h" > >> > > >> > int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2) > >> > > >> > >> > >> Nice that this warning is finally fixed - but what is the point of > >> including all those headers at all here? [1] worked well for me while > >> reducing dependencies. > > > > I think all header files should be checked and even reorganized when > > necessary. One item is the dyngen removal, cpu.h/exec.h distinction is > > not clear for all targets and headers used by both user and system > > emulators could be adjusted. Header files in hw should be OK, but > > worth checking. > > > Header dependencies and usage policies should be rechecked and probably > cleaned up now, no question (see also my dyngen-exec.h problems). > > But here I was referring to the need of this _particular_ C file for any > header except inttypes.h. Why including headers _here_ for no use? That particular case looks fine.