From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBmFU-0002wX-77
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 03:22:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBmFT-0002wH-0M
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 03:22:47 -0500
Received: from [199.232.76.173] (port=42875 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBmFS-0002wE-Qo
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 03:22:46 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:57155)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LBmFS-00073c-7H
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 03:22:46 -0500
Received: by bwz5 with SMTP id 5so3527922bwz.10
	for <qemu-devel@nongnu.org>; Sun, 14 Dec 2008 00:22:44 -0800 (PST)
Message-ID: <f43fc5580812140022ob42056bs5d2c9f2664aa1e72@mail.gmail.com>
Date: Sun, 14 Dec 2008 10:22:44 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [6000] Remove unnecessary trailing newlines
In-Reply-To: <Pine.LNX.4.64.0812132357090.4050@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1LBQrc-0005g6-A1@cvs.savannah.gnu.org>
	<Pine.LNX.4.64.0812132357090.4050@linmac.oyster.ru>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/13/08, malc <av1474@comtv.ru> wrote:
> On Sat, 13 Dec 2008, Blue Swirl wrote:
>
>
> > Revision: 6000
> >
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6000
> > Author:   blueswir1
> > Date:     2008-12-13 09:32:43 +0000 (Sat, 13 Dec 2008)
> >
> > Log Message:
> > -----------
> > Remove unnecessary trailing newlines
> >
> >
>
>  [..snip..]
>
>  Perhaps we should remove also all the tabs and add a pre-commit hook
>  that will reject the malformed checkins (extraneous newlines, CRs,
>  etc)?

A pre-commit hook would be nice, like also a published checkpatch.pl
for patch submitters to check the style of the patch. A lot of patches
are submitted that draw the same comments about incorrect white space
use.

About tabs, while I don't like them, maybe others have good reasons
for using those.