From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBpsu-0005v4-S4
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 07:15:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBpst-0005sz-0n
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 07:15:44 -0500
Received: from [199.232.76.173] (port=44386 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBpss-0005sm-RW
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 07:15:42 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:47615)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LBpss-0001Vh-Eo
	for qemu-devel@nongnu.org; Sun, 14 Dec 2008 07:15:42 -0500
Received: by bwz5 with SMTP id 5so3639213bwz.10
	for <qemu-devel@nongnu.org>; Sun, 14 Dec 2008 04:15:41 -0800 (PST)
Message-ID: <f43fc5580812140415t1039e4f1vfdcbd4b570e8553d@mail.gmail.com>
Date: Sun, 14 Dec 2008 14:15:41 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [6023] Use a hex value instead of possibly ambiguous
	8 bit character
In-Reply-To: <alpine.DEB.1.00.0812141217390.2014@eeepc-johanness>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1LBnJB-00069f-Ox@cvs.savannah.gnu.org>
	<alpine.DEB.1.00.0812141118020.2014@eeepc-johanness>
	<f43fc5580812140241u14b1438fjef02000effbbc9fc@mail.gmail.com>
	<alpine.DEB.1.00.0812141151250.2014@eeepc-johanness>
	<jer64bhuzy.fsf@sykes.suse.de>
	<alpine.DEB.1.00.0812141217390.2014@eeepc-johanness>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Andreas Schwab <schwab@suse.de>, qemu-devel@nongnu.org

On 12/14/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
>  Please Cc: me, I only did not miss your message because it is a slow
>  Sunday morning (_and_ I am not in a deep hacking session).
>
>
>
>
>  On Sun, 14 Dec 2008, Andreas Schwab wrote:
>
>  > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>  >
>  > > +#define ADD_CHAR(c) buffer[j++] = (c) ? '.' : (c)
>
>
> Oops.  This is obviously wrong, and should read
>
>
>  #define ADD_CHAR(c) buffer[j++] = (c) < ' ' ? '.' : (c)
>
>  > isprint(c) perhaps?
>
>
> I vote against using isprint(c).  The code is simple as it is, otherwise
>  you'd have to look up what isprint() does, _and_ rely on isprint() being
>  present.

I agree that we should not use plain old isprint, but instead the
highly advanced, omnipresent qemu_isprint which has none of the
problems of what isprint may have. ;-)