From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LCc0f-0006p9-DS
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 10:38:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LCc0e-0006oR-KZ
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 10:38:56 -0500
Received: from [199.232.76.173] (port=34062 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LCc0e-0006o8-6a
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 10:38:56 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:59345)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LCc0d-0005hN-Oy
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 10:38:56 -0500
Received: by bwz5 with SMTP id 5so5959220bwz.10
	for <qemu-devel@nongnu.org>; Tue, 16 Dec 2008 07:38:53 -0800 (PST)
Message-ID: <f43fc5580812160736gada0942l861490b10dd64cc6@mail.gmail.com>
Date: Tue, 16 Dec 2008 17:36:19 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Time drift again.
In-Reply-To: <20081216150211.GH13794@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081216122511.GE13794@redhat.com>
	<200812161233.31503.paul@codesourcery.com>
	<20081216123812.GF13794@redhat.com>
	<20081216150211.GH13794@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 12/16/08, Gleb Natapov <gleb@redhat.com> wrote:
>   #ifdef TARGET_I386
>   int win2k_install_hack = 0;
>   #endif
>  +int rtc_td_hack = 0;

>   #ifdef TARGET_I386
>             "-win2k-hack     use it when installing Windows 2000 to avoid a disk full bug\n"
>   #endif
>  +           "-rtc-td-hack    use it to fix time drift in Windows ACPI HAL\n"

>      QEMU_OPTION_win2k_hack,
>  +    QEMU_OPTION_rtc_td_hack,

>      { "win2k-hack", 0, QEMU_OPTION_win2k_hack },
>  +    { "rtc-td-hack", 0, QEMU_OPTION_rtc_td_hack },

>                  win2k_install_hack = 1;
>                  break;
>   #endif
>  +            case QEMU_OPTION_rtc_td_hack:
>  +                rtc_td_hack = 1;
>  +                break;
>   #ifdef USE_KQEMU

Like win2k-hack, the code and variable definitions should be
conditional to TARGET_I386, just by moving the #endif a few lines.